Clarify automatic error detection description - #881
Conversation
Explain that failed command detection happens automatically while sending failures to an agent for automatic fixes is optional. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52d2b227-75a7-4bac-a207-ffae095c3423
There was a problem hiding this comment.
🟡 Changes recommended
The zh-TW updated string uses terminology (“AI 代理”) that is inconsistent with other zh-TW strings in the same file and can conflict with the intended “AI agent” meaning noted in the resource comment.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Settings Editor’s localized description for the AI “Error detection” setting to clarify that failed commands are detected locally in the shell, and that sending failures to an AI agent for automatic fixes is optional.
Changes:
- Revised
AIAgents_AutoErrorHandlingDescription.Textwording in en-US and propagated the updated copy to all Settings Editor locales. - Updated pseudo-locales (
qps-*) to keep the English fallback text aligned with en-US.
File summaries
| File | Description |
|---|---|
| src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw | Updates zh-TW error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw | Updates zh-CN error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw | Updates uk-UA error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw | Updates sr-Cyrl-RS error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw | Updates ru-RU error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw | Updates pseudo-locale fallback text to match en-US. |
| src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw | Updates pseudo-locale fallback text to match en-US. |
| src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw | Updates pseudo-locale fallback text to match en-US. |
| src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw | Updates pt-BR error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw | Updates ko-KR error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw | Updates ja-JP error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw | Updates it-IT error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw | Updates fr-FR error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw | Updates es-ES error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw | Updates the source (en-US) error-detection description text. |
| src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw | Updates de-DE error-detection description text. |
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
866bfb3 to
cf1af58
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The zh-TW resource file changes introduce mixed line endings/stray \r characters in the modified region, and the updated en-US wording may inaccurately imply auto-applying fixes rather than suggesting them.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (2)
src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw:2879
- This line still contains a stray carriage-return character (visible as
\r) at the end of the line, indicating mixed line endings in this region. Please normalize it to match the file’s standard line endings.
<value>自動偵測殼層中失敗的命令，並可選擇將其傳送給您的 AI 代理進行自動修正。</value>
src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw:2854
- These AIAgents_PanePosition entries contain stray carriage-return characters (visible as
\r), which indicates mixed/invalid line endings in the middle of the XML. This creates unnecessary diff noise and can be fragile for tooling; please normalize these lines to the file’s standard line endings.
This issue also appears on line 2879 of the same file.
<data name="AIAgents_PanePosition.HelpText" xml:space="preserve"><value>代理程式所在的位置</value><comment>Supplementary description for the pane position setting.</comment></data>
<data name="AIAgents_PanePosition_Bottom" xml:space="preserve">
<value>底部</value>
<comment>Value shown in the agent pane position dropdown (selects which side of the terminal the agent pane opens on). Translation should match the existing FreOverlay_PanePositionBottom string used in the first-run experience.</comment>
</data>
- Files reviewed: 16/16 changed files
- Comments generated: 1
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The change is a consistent, localized copy update across the expected locale set with no functional code impact observed.
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 0 new
- Review effort level: Lite
Summary
Validation