Skip to content

Settings polish: refine the Agent settings layout #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yuandi (DDKinger) merged 7 commits into from
Sep 7, 2026
Merged

Settings polish: refine the Agent settings layout #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7710d9
Settings polish: reorder Agent page settings
DDKinger Sep 7, 2026
d9c6325
Settings polish: align the Yolo mode toggle
DDKinger Sep 7, 2026
2d415af
Settings polish: align custom model actions
DDKinger Sep 7, 2026
31717ee
Settings polish: keep custom model actions equal width
DDKinger Sep 7, 2026
4099bc8
Settings polish: allow localized custom model actions
DDKinger Sep 7, 2026
c35973d
Settings polish: restore compact custom model actions
DDKinger Sep 7, 2026
b3dec77
Settings polish: rename the custom endpoint action
DDKinger Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 49 additions & 41 deletions src/cascadia/TerminalSettingsEditor/AIAgents.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@
x:Uid="AIAgents_CustomProviderRemove"
VerticalAlignment="Center"
Click="{x:Bind Remove}"
MinWidth="120" />
Width="120" />
<muxc:InfoBar Grid.Row="1"
Grid.ColumnSpan="2"
Margin="0,12,0,0"
Expand All @@ -304,10 +304,17 @@

<Border Padding="0,4"
Visibility="{x:Bind mtu:Converters.InvertedBooleanToVisibility(ViewModel.IsAddingCustomModelProvider), Mode=OneWay}">
<Button x:Uid="AIAgents_CustomProviderAdd"
HorizontalAlignment="Right"
Click="{x:Bind ViewModel.AddCustomModelProvider}"
Style="{StaticResource AccentButtonStyle}" />
<Grid>
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*" />
<ColumnDefinition Width="Auto" />
</Grid.ColumnDefinitions>
<Button Grid.Column="1"
x:Uid="AIAgents_CustomProviderAdd"
Comment thread
DDKinger marked this conversation as resolved.
Click="{x:Bind ViewModel.AddCustomModelProvider}"
Width="120"
Style="{StaticResource AccentButtonStyle}" />
</Grid>
</Border>

<Border Padding="0,8,0,16"
Expand Down Expand Up @@ -381,42 +388,6 @@
Style="{StaticResource ComboBoxSettingStyle}" />
</local:SettingContainer>

<!-- Global Yolo preference: asks supported providers to enable
their advertised ACP session mode. High-risk toggle, so it
is disabled outright (IsYoloModePolicyLocked) when the
AllowYoloMode GPO policy blocks it. -->
<local:SettingContainer x:Name="AgentPaneYoloMode"
x:Uid="AIAgents_YoloMode">
<StackPanel>
<ToggleSwitch AutomationProperties.AutomationId="AgentPaneYoloModeToggle"
IsOn="{x:Bind ViewModel.AgentPaneYoloMode, Mode=TwoWay}"
IsEnabled="{x:Bind mtu:Converters.InvertBoolean(ViewModel.IsYoloModePolicyLocked), Mode=OneWay}"
Style="{StaticResource ToggleSwitchInExpanderStyle}" />
<TextBlock x:Uid="AIAgents_PolicyLocked"
Visibility="{x:Bind ViewModel.IsYoloModePolicyLocked, Mode=OneWay}"
Opacity="0.6"
Margin="0,4,0,0" />
</StackPanel>
</local:SettingContainer>
<muxc:InfoBar x:Uid="AIAgents_YoloOpenCodeWarning"
AutomationProperties.AutomationId="OpenCodeYoloCompatibilityInfoBar"
HorizontalAlignment="Stretch"
IsClosable="False"
IsOpen="{x:Bind ViewModel.ShowOpenCodeYoloWarning, Mode=OneWay}"
Margin="0,4,0,0"
MaxWidth="1000"
Severity="Warning"
Visibility="{x:Bind ViewModel.ShowOpenCodeYoloWarning, Mode=OneWay}" />
<muxc:InfoBar x:Uid="AIAgents_YoloGeminiInfo"
AutomationProperties.AutomationId="GeminiYoloCompatibilityInfoBar"
HorizontalAlignment="Stretch"
IsClosable="False"
IsOpen="{x:Bind ViewModel.ShowGeminiYoloInfo, Mode=OneWay}"
Margin="0,4,0,0"
MaxWidth="1000"
Severity="Informational"
Visibility="{x:Bind ViewModel.ShowGeminiYoloInfo, Mode=OneWay}" />

<local:SettingContainer x:Name="AutoErrorHandling"
Style="{StaticResource AutoErrorHandlingSettingContainerStyle}">
<local:SettingContainer.Header>
Expand Down Expand Up @@ -467,6 +438,43 @@
IsOn="{x:Bind ViewModel.ShowTokenUsageAndCost, Mode=TwoWay}" />
</local:SettingContainer>

<!-- Global Yolo preference: asks supported providers to enable
their advertised ACP session mode. High-risk toggle, so it
is disabled outright (IsYoloModePolicyLocked) when the
AllowYoloMode GPO policy blocks it. -->
<local:SettingContainer x:Name="AgentPaneYoloMode"
Comment thread
DDKinger marked this conversation as resolved.
x:Uid="AIAgents_YoloMode">
<StackPanel>
<ToggleSwitch AutomationProperties.AutomationId="AgentPaneYoloModeToggle"
AutomationProperties.AccessibilityView="Content"
MinWidth="0"
IsOn="{x:Bind ViewModel.AgentPaneYoloMode, Mode=TwoWay}"
IsEnabled="{x:Bind mtu:Converters.InvertBoolean(ViewModel.IsYoloModePolicyLocked), Mode=OneWay}" />
Comment thread
DDKinger marked this conversation as resolved.
<TextBlock x:Uid="AIAgents_PolicyLocked"
Visibility="{x:Bind ViewModel.IsYoloModePolicyLocked, Mode=OneWay}"
Opacity="0.6"
Margin="0,4,0,0" />
</StackPanel>
</local:SettingContainer>
<muxc:InfoBar x:Uid="AIAgents_YoloOpenCodeWarning"
AutomationProperties.AutomationId="OpenCodeYoloCompatibilityInfoBar"
HorizontalAlignment="Stretch"
IsClosable="False"
IsOpen="{x:Bind ViewModel.ShowOpenCodeYoloWarning, Mode=OneWay}"
Margin="0,4,0,0"
MaxWidth="1000"
Severity="Warning"
Visibility="{x:Bind ViewModel.ShowOpenCodeYoloWarning, Mode=OneWay}" />
<muxc:InfoBar x:Uid="AIAgents_YoloGeminiInfo"
AutomationProperties.AutomationId="GeminiYoloCompatibilityInfoBar"
HorizontalAlignment="Stretch"
IsClosable="False"
IsOpen="{x:Bind ViewModel.ShowGeminiYoloInfo, Mode=OneWay}"
Margin="0,4,0,0"
MaxWidth="1000"
Severity="Informational"
Visibility="{x:Bind ViewModel.ShowGeminiYoloInfo, Mode=OneWay}" />

<!-- ═══ Command palette group ═══ -->
<TextBlock x:Uid="AIAgents_DelegateGroupHeader"
Style="{StaticResource TextBlockSubHeaderStyle}" />
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/de-DE/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2977,7 +2977,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Abbrechen</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
4 changes: 2 additions & 2 deletions src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3053,7 +3053,7 @@ In this context, "agent" refers to an AI agent (e.g. Copilot, Claude, Gemini), n
<comment>{Locked="API"} Hint below the optional custom provider credential input. Use the established localized product name for Windows Credential Manager.</comment>
</data>
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<value>Add endpoint</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
Expand All @@ -3066,7 +3066,7 @@ In this context, "agent" refers to an AI agent (e.g. Copilot, Claude, Gemini), n
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Cancel</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/es-ES/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2977,7 +2977,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Cancelar</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/fr-FR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2978,7 +2978,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Annuler</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/it-IT/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2977,7 +2977,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Annulla</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/ja-JP/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2977,7 +2977,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>キャンセル</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/ko-KR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3022,7 +3022,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>취소</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/pt-BR/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3009,7 +3009,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Cancelar</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
4 changes: 2 additions & 2 deletions src/cascadia/TerminalSettingsEditor/Resources/qps-ploc/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2959,7 +2959,7 @@
<comment>{Locked="API"} Hint below the optional custom provider credential input. Use the established localized product name for Windows Credential Manager.</comment>
</data>
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<value>Add endpoint</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
Expand All @@ -2972,7 +2972,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Cancel</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
4 changes: 2 additions & 2 deletions src/cascadia/TerminalSettingsEditor/Resources/qps-ploca/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2959,7 +2959,7 @@
<comment>{Locked="API"} Hint below the optional custom provider credential input. Use the established localized product name for Windows Credential Manager.</comment>
</data>
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<value>Add endpoint</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
Expand All @@ -2972,7 +2972,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Cancel</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
4 changes: 2 additions & 2 deletions src/cascadia/TerminalSettingsEditor/Resources/qps-plocm/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2959,7 +2959,7 @@
<comment>{Locked="API"} Hint below the optional custom provider credential input. Use the established localized product name for Windows Credential Manager.</comment>
</data>
<data name="AIAgents_CustomProviderAdd.Content" xml:space="preserve">
<value>Add New</value>
<value>Add endpoint</value>
<comment>Button in the final custom provider row that reveals the fields for adding another endpoint.</comment>
</data>
<data name="AIAgents_CustomProviderSave.Content" xml:space="preserve">
Expand All @@ -2972,7 +2972,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Cancel</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/ru-RU/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3009,7 +3009,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Отменить</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/sr-Cyrl-RS/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3024,7 +3024,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Откажи</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/uk-UA/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2681,7 +2681,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>Скасувати</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/zh-CN/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3022,7 +3022,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>取消</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Resources/zh-TW/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2977,7 +2977,7 @@
</data>
<data name="AIAgents_CustomProviderCancel.Content" xml:space="preserve">
<value>取消</value>
<comment>Button that cancels adding a provider and restores the Add New row.</comment>
<comment>Button that cancels adding a provider and restores the Add endpoint row.</comment>
</data>
<data name="AIAgents_BYOKModelDisplayName" xml:space="preserve">
<value>{} (BYOK)</value>
Expand Down
Loading