[OpenTelemetry] Turn off gcp otel auth extension by default.#38940
[OpenTelemetry] Turn off gcp otel auth extension by default.#38940stankiewicz wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the OpenTelemetry initialization logic in both the StreamingDataflowWorker and the FnHarness. By explicitly disabling the GCP auth extension when auto-configuration is not in use, it ensures that users can provide their own OpenTelemetry configurations without unexpected side effects from the default auth extension. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the Google OpenTelemetry auth extension by setting the 'google.otel.auth.target.signals' system property to 'none' when OpenTelemetry is not enabled in both StreamingDataflowWorker and FnHarness. The reviewer recommended checking if this system property is already set before overriding it to prevent overwriting any user-defined JVM arguments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } else { | ||
| // turn off auth extension so it doesn't interfere if user is configuring otel e.g. via | ||
| // JvmInitializer. | ||
| System.setProperty("google.otel.auth.target.signals", "none"); | ||
| } |
There was a problem hiding this comment.
Unconditionally setting the system property google.otel.auth.target.signals will overwrite any value explicitly configured by the user (e.g., via command-line JVM arguments like -Dgoogle.otel.auth.target.signals=...). It is safer to check if the property is already set before overriding it.
| } else { | |
| // turn off auth extension so it doesn't interfere if user is configuring otel e.g. via | |
| // JvmInitializer. | |
| System.setProperty("google.otel.auth.target.signals", "none"); | |
| } | |
| } else { | |
| // turn off auth extension so it doesn't interfere if user is configuring otel e.g. via | |
| // JvmInitializer. | |
| if (System.getProperty("google.otel.auth.target.signals") == null) { | |
| System.setProperty("google.otel.auth.target.signals", "none"); | |
| } | |
| } |
| } else { | ||
| // turn off auth extension so it doesn't interfere if user is configuring otel e.g. via | ||
| // JvmInitializer. | ||
| System.setProperty("google.otel.auth.target.signals", "none"); | ||
| } |
There was a problem hiding this comment.
Unconditionally setting the system property google.otel.auth.target.signals will overwrite any value explicitly configured by the user (e.g., via command-line JVM arguments like -Dgoogle.otel.auth.target.signals=...). It is safer to check if the property is already set before overriding it.
} else {
// turn off auth extension so it doesn't interfere if user is configuring otel e.g. via
// JvmInitializer.
if (System.getProperty("google.otel.auth.target.signals") == null) {
System.setProperty("google.otel.auth.target.signals", "none");
}
}
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
1 participant
OpenTelemetry gcp auth extension is added as dependency and there is risk that it may interfere with user configuration.
This setting will turn off configuration of it if auto configuration is used.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.