Skip to content

[OpenTelemetry] Turn off gcp otel auth extension by default. #38940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

[OpenTelemetry] Turn off gcp otel auth extension by default. #38940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,6 +1059,10 @@ public static void main(String[] args) throws Exception {
}
});
LOG.info("Enabled Open Telemetry with properties: {}", openTelemetryProperties);
} else {
// turn off auth extension so it doesn't interfere if user is configuring otel e.g. via
// JvmInitializer.
System.setProperty("google.otel.auth.target.signals", "none");
}
Comment on lines +1062 to 1066

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Unconditionally setting the system property google.otel.auth.target.signals will overwrite any value explicitly configured by the user (e.g., via command-line JVM arguments like -Dgoogle.otel.auth.target.signals=...). It is safer to check if the property is already set before overriding it.

Suggested change
} else {
// turn off auth extension so it doesn't interfere if user is configuring otel e.g. via
// JvmInitializer.
System.setProperty("google.otel.auth.target.signals", "none");
}
} else {
// turn off auth extension so it doesn't interfere if user is configuring otel e.g. via
// JvmInitializer.
if (System.getProperty("google.otel.auth.target.signals") == null) {
System.setProperty("google.otel.auth.target.signals", "none");
}
}


LOG.debug("Creating StreamingDataflowWorker from options: {}", options);
Expand Down
4 changes: 4 additions & 0 deletions sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,10 @@ public static void main(
}
});
LOG.info("Enabled Open Telemetry with properties: {}", openTelemetryProperties);
} else {
// turn off auth extension so it doesn't interfere if user is configuring otel e.g. via
// JvmInitializer.
System.setProperty("google.otel.auth.target.signals", "none");
}
Comment on lines +309 to 313

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Unconditionally setting the system property google.otel.auth.target.signals will overwrite any value explicitly configured by the user (e.g., via command-line JVM arguments like -Dgoogle.otel.auth.target.signals=...). It is safer to check if the property is already set before overriding it.

      } else {
        // turn off auth extension so it doesn't interfere if user is configuring otel e.g. via
        // JvmInitializer.
        if (System.getProperty("google.otel.auth.target.signals") == null) {
          System.setProperty("google.otel.auth.target.signals", "none");
        }
      }

EnumMap<
BeamFnApi.InstructionRequest.RequestCase,
Expand Down
Loading