Skip to content

[Handshake] Increase LSQ load/store queue to hold largest group #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxWipfli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Handshake] Increase LSQ load/store queue to hold largest group #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 30 additions & 13 deletions lib/Dialect/Handshake/MemoryInterfaces.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "llvm/ADT/Twine.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MathExtras.h"
#include <algorithm>

using namespace llvm;
using namespace mlir;
Expand Down Expand Up @@ -316,19 +317,6 @@ void LSQGenerationInfo::fromPorts(FuncMemoryPorts &ports) {
dataWidth = ports.dataWidth;
addrWidth = ports.addrWidth;

handshake::LSQDepthAttr lsqDepthAttr =
getDialectAttr<handshake::LSQDepthAttr>(lsqOp);
if (lsqDepthAttr) {
depthLoad = lsqDepthAttr.getLoadQueueDepth();
depthStore = lsqDepthAttr.getStoreQueueDepth();
// "depth" Parameter is theoretically unused, but still needed by the
// current LSQGenerator
depth = std::max(depthLoad, depthStore);
} else {
depthLoad = 16;
depthStore = 16;
}

numGroups = ports.getNumGroups();
numLoads = ports.getNumPorts<LoadPort>();
numStores = ports.getNumPorts<StorePort>();
Expand Down Expand Up @@ -394,6 +382,35 @@ void LSQGenerationInfo::fromPorts(FuncMemoryPorts &ports) {
ldOrder.push_back(ldOrderOfOneGroup);
}

unsigned maxLoadsPerGroup =
*std::max_element(loadsPerGroup.begin(), loadsPerGroup.end());
unsigned maxStoresPerGroup =
*std::max_element(storesPerGroup.begin(), storesPerGroup.end());

/// Determine load and store queue sizes
handshake::LSQDepthAttr lsqDepthAttr =
getDialectAttr<handshake::LSQDepthAttr>(lsqOp);
if (lsqDepthAttr) {
depthLoad = lsqDepthAttr.getLoadQueueDepth();
depthStore = lsqDepthAttr.getStoreQueueDepth();
} else {
// Use default depth of 16.
depthLoad = 16;
depthStore = 16;
}

// If the load/store queues are not large enough to hold a single group at
// once, increase their sizes to the minimum valid depth (i.e., the maximum
// number of loads/stores in a group + 1)
if (maxLoadsPerGroup >= depthLoad)
depthLoad = maxLoadsPerGroup + 1;
if (maxStoresPerGroup >= depthStore)
depthStore = maxStoresPerGroup + 1;

// "depth" Parameter is theoretically unused, but still needed by the
// current LSQGenerator
depth = std::max(depthLoad, depthStore);

/// Adds as many 0s as necessary to the array so that its size equals the
/// depth. Asserts if the array size is larger than the depth.
auto capArray = [&](SmallVector<unsigned> &array, unsigned depth) -> void {
Expand Down
Loading