[Handshake] Increase LSQ load/store queue to hold largest group#1004
Open
MaxWipfli wants to merge 1 commit into
Open
[Handshake] Increase LSQ load/store queue to hold largest group#1004MaxWipfli wants to merge 1 commit into
MaxWipfli wants to merge 1 commit into
Conversation
Collaborator
|
oh this is an interesting idea, yes makes sense 😁 |
08be395 to
e728763
Compare
Collaborator
Author
|
There is an alternative solution to handle large groups without exploding queue sizes (e.g., if there is a large group that is only executed once per kernel): In particular, a single group could be split into multiple smaller groups (either in C++, or this could even be done by the LSQ generator internally), so that a single basic block could consist of multiple groups. However, this should only be implemented if it actually becomes a problem in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a single basic block (= group) has too many loads/stores, the LSQ must use larger load/store queues since allocation needs to happen at once. If there are at most L load and S stores in a single group, then the LSQ's load queue depth must be L+1 and the store queue depth must be S+1.
An assertion to ensure this in the LSQ generator was already added in #993. This now ensures that the C++ code always emits valid load/store queue sizes.
This fixes #832.