Add on-the-fly notification config and change events to strings#233
Merged
thiagoesteves merged 5 commits intoJun 19, 2026
Merged
Conversation
thiagoesteves
commented
Jun 19, 2026
thiagoesteves
commented
Owner
- Change all notification event identifiers from atoms to strings throughout (yaml parsing, adapters, workers, call sites, and tests)
- Add Foundation.Notifications.stop/start_notification_manager to stop all workers and restart them from a new config list
- Wire :notifications into Sentinel.Config.Watcher so changes detected in the YAML are applied at runtime without a restart
- Add :notifications field to Sentinel.Config.Upgradable and Changes
- Add a dedicated render_change_section for :notifications in the config changes modal to avoid a crash when rendering struct lists
- Change all notification event identifiers from atoms to strings throughout (yaml parsing, adapters, workers, call sites, and tests) - Add Foundation.Notifications.stop/start_notification_manager to stop all workers and restart them from a new config list - Wire :notifications into Sentinel.Config.Watcher so changes detected in the YAML are applied at runtime without a restart - Add :notifications field to Sentinel.Config.Upgradable and Changes - Add a dedicated render_change_section for :notifications in the config changes modal to avoid a crash when rendering struct lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.