Update changelog and docs for 0.9.4#234
Merged
Merged
Conversation
…cate_valid event
- Fix initialize_notification_manager/0 which was iterating the notifications
list with Enum.each before calling start_notification_manager/1, causing it
to receive a single struct instead of the full list and crash.
- Parse the notifications options: key into %Foundation.Yaml.Notification.Options{}
instead of a plain atomised map, aligning runtime values with the declared @type.
Convert the nested struct to a plain map when building the Worker so adapters
can still access options with options[:key].
- Split request_and_import_certificate/2 return into {:ok, :renewed, cert} and
{:ok, :valid, cert} so certificate_renewed only fires on actual renewals.
Add a new certificate_valid event that fires when a periodic check finds an
already-valid certificate, preventing misleading "renewed" notifications.
- Register certificate_valid in @valid_notification_events, document it in all
adapter modules, add it to dev.exs and the installer YAML templates, and cover
all changes with new and updated unit tests.
…orted event When "all" is listed as the sole event in a notifications entry, the YAML parser now expands it to all entries in @valid_notification_events. This avoids listing every event explicitly and automatically picks up new events added in the future. Updated docs (notifications.ex, Yaml.Notification, README.md) and installer YAML templates to show the "all" usage. Added yaml_test covering the expansion.
thiagoesteves
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation.NotificationsandFoundation.Notifications.Adapterdocstrings to fix minor wording inconsistencies introduced in those PRs
🤖 Generated with Claude Code