Skip to content

fix race in TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3 #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moody-temporal wants to merge 4 commits into
base: main
Choose a base branch
from
+39 −25
Open

fix race in TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3 #10538

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93e813a
fix race in TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3
moody-temporal Jun 4, 2026
9b4fc4b
refactor to use await instead of channels
moody-temporal Jun 5, 2026
d9dd9c2
fmt
moody-temporal Jun 5, 2026
7b8ab7a
Merge branch 'main' into fix-data-race-in-matching-tests
moody-temporal Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions service/matching/matching_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,6 +2697,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_FromNoth
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()

updateErrCh := make(chan error, 1)
go func() {
time.Sleep(200 * time.Millisecond)

Expand All @@ -2715,7 +2716,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_FromNoth
},
},
})
s.NoError(err)
updateErrCh <- err
}()

res, err := s.matchingEngine.GetTaskQueueUserData(ctx, &matchingservice.GetTaskQueueUserDataRequest{
Expand All @@ -2725,6 +2726,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_FromNoth
LastKnownUserDataVersion: 0, // must be zero to start
WaitNewData: true,
})
s.NoError(<-updateErrCh)
s.NoError(err)
s.NotNil(res.UserData.Data.VersioningData)
}
Expand All @@ -2751,6 +2753,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()

updateErrCh := make(chan error, 1)
go func() {
time.Sleep(200 * time.Millisecond)

Expand All @@ -2769,7 +2772,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3
},
},
})
s.NoError(err)
updateErrCh <- err
}()

res, err := s.matchingEngine.GetTaskQueueUserData(ctx, &matchingservice.GetTaskQueueUserDataRequest{
Expand All @@ -2779,6 +2782,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3
LastKnownUserDataVersion: userData.Version,
WaitNewData: true,
})
s.NoError(<-updateErrCh)
s.NoError(err)
s.True(hlc.Greater(res.UserData.Data.Clock, userData.Data.Clock))
s.NotNil(res.UserData.Data.VersioningData)
Expand Down
Loading