fix race in TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3#10538
Open
moody-temporal wants to merge 4 commits into
Open
fix race in TestGetTaskQueueUserData_LongPoll_WakesUp_From2to3#10538moody-temporal wants to merge 4 commits into
moody-temporal wants to merge 4 commits into
Conversation
We can't run s.NoError() from within the child goroutine, instead make a channel and just chuck it over to the main thread.
stephanos
approved these changes
Jun 4, 2026
stephanos
reviewed
Jun 4, 2026
Comment on lines
2700
to
2720
| @@ -2715,7 +2716,7 @@ func (s *matchingEngineSuite) TestGetTaskQueueUserData_LongPoll_WakesUp_FromNoth | |||
| }, | |||
| }, | |||
| }) | |||
| s.NoError(err) | |||
| updateErrCh <- err | |||
| }() | |||
Contributor
There was a problem hiding this comment.
actually - why not use eventually/await? it does the same thing under the hood but safer (has timeout etc)
Contributor
Author
There was a problem hiding this comment.
Gave that a go, caused a bit more of a refactor than I would have liked but I think the result is better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't run s.NoError() from within the child goroutine, instead make a channel and just chuck it over to the main thread.
How did you test it?