Skip to content

fix: call logout request on logout#1197

Merged
Dadadah merged 2 commits into
stoatchat:mainfrom
Dadadah:fix/logout
Jun 19, 2026
Merged

fix: call logout request on logout#1197
Dadadah merged 2 commits into
stoatchat:mainfrom
Dadadah:fix/logout

Conversation

@Dadadah

@Dadadah Dadadah commented May 24, 2026

Copy link
Copy Markdown
Member

On logout, call the logout function which deletes the session.

Fixes #910

How was this PR tested?

Logged out and observed session being deleted.

Checklist:

  • I have carefully read the contributing guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR
  • I have confirmed that any new dependencies are strictly necessary
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code

Please declare, if any, LLM usage involved in creating this PR

None

Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
@Dadadah Dadadah requested review from a team as code owners May 24, 2026 01:44
@Dadadah Dadadah requested a review from Pecacheu May 29, 2026 06:06
@Pecacheu

Pecacheu commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

I'll have to double-check the implications this will have on #1217 since that also messes with the logout function but doesn't fully log out (nor unsubscribe from push) so that accounts can be switched back and forth.

May cause a merge conflict but it should be easy to fix.

@Pecacheu

Pecacheu commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

K tested w/ multiuser PR, small conflict as predicted but easy to fix and it still works (only unsubscribes from push when logging out and not switching users)

@Dadadah

Dadadah commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

Waiting for v0.8.0 to release before merging.

@Dadadah Dadadah merged commit 21c64ce into stoatchat:main Jun 19, 2026
10 checks passed
Pecacheu pushed a commit to Pecacheu/for-web that referenced this pull request Jun 22, 2026
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

login session still shows after log out

3 participants