fix: call logout request on logout#1197
Merged
Merged
Conversation
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
chrishultin
approved these changes
Jun 1, 2026
Contributor
|
I'll have to double-check the implications this will have on #1217 since that also messes with the logout function but doesn't fully log out (nor unsubscribe from push) so that accounts can be switched back and forth. May cause a merge conflict but it should be easy to fix. |
Contributor
|
K tested w/ multiuser PR, small conflict as predicted but easy to fix and it still works (only unsubscribes from push when logging out and not switching users) |
Pecacheu
approved these changes
Jun 1, 2026
Member
Author
|
Waiting for v0.8.0 to release before merging. |
Pecacheu
pushed a commit
to Pecacheu/for-web
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On logout, call the logout function which deletes the session.
Fixes #910
How was this PR tested?
Logged out and observed session being deleted.
Checklist:
Please declare, if any, LLM usage involved in creating this PR
None