fix: call logout request on logout (stoatchat#1197)

Signed-off-by: Jacob Schlecht <dadadah@echoha.us>

Author: Dadadah

packages/client/components/client/Controller.ts

@@ -121,9 +121,7 @@ class Lifecycle {
 
   private dispose() {
     if (this.client) {
-      this.client.events.removeAllListeners();
-      this.client.removeAllListeners();
-      this.client.events.disconnect();
+      this.client.logout();
     }
 
     this.client = new Client({
@@ -599,7 +597,7 @@ export default class ClientController {
 
   logout() {
     this.state.settings.resetNotificationsState();
-    killServiceWorkerSubscription(this.getCurrentClient());
+    killServiceWorkerSubscription(this.getCurrentClient(), true);
     this.state.auth.removeSession();
     this.lifecycle.transition({
       type: TransitionType.Logout,

packages/client/components/client/NotificationsController.ts

@@ -173,7 +173,10 @@ function arrayBufferToBase64URL(buffer: ArrayBuffer): string {
 }
 
 /** Exported for the client controller. Don't use this unless you have to. */
-export async function killServiceWorkerSubscription(client: Client) {
+export async function killServiceWorkerSubscription(
+  client: Client,
+  loggingOut?: boolean,
+) {
   if (IS_DEV) {
     console.log("Skipping killing push worker in dev.");
     return;
@@ -183,6 +186,6 @@ export async function killServiceWorkerSubscription(client: Client) {
   if (!registration) return;
   const subscription = await registration.pushManager.getSubscription();
   if (await subscription?.unsubscribe()) {
-    await client.api.post("/push/unsubscribe");
+    if (!loggingOut) await client.api.post("/push/unsubscribe");
   }
 }