Skip to content

return NOT_EVALUATED for percent checks #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bujjibabukatta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

return NOT_EVALUATED for percent checks #2708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions soda-core/src/soda_core/contracts/impl/contract_verification_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1741,8 +1741,9 @@ def compute_derived_value(self, measurement_values: MeasurementValues) -> Option
if values is None:
return None
fraction, total = values
return (fraction * 100 / total) if total != 0 else 0

if total == 0:
return None # No rows to evaluate; let evaluate_threshold return NOT_EVALUATED
return fraction * 100 / total

class ValidCountMetric(AggregationMetricImpl):
"""TODO -- 3/10/2025: this metric is not used anywhere in the codebase, it's not clear if it's needed."""
Expand Down