return NOT_EVALUATED for percent checks#2708
Open
bujjibabukatta wants to merge 1 commit into
Open
Conversation
evaluate_threshold correctly returns NOT_EVALUATED instead.
|
|
|
bramhanandlingala
approved these changes
May 18, 2026
bramhanandlingala
approved these changes
May 19, 2026
S4srihari
approved these changes
May 19, 2026
Author
|
can you please verify pull request and merge it @Niels-b |
bramhanandlingala
approved these changes
May 19, 2026
Author
|
can you please verify and merge pull request @CLAassistant . |
Author
|
Hi @Niels-b @m1n0 could you please take a look at this PR Pre-commit CI is failing due to a pre-existing issue in Can a maintainer advise or re-run CI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: return NOT_EVALUATED for percent checks when row_count is zero
When a filter excludes all rows (row_count = 0), percent-based checks
(missing_percent, invalid_percent) previously computed 0.0 and evaluated
the threshold against it, causing unexpected FAILED results.
Return None from DerivedPercentageMetricImpl when total is 0 so that
evaluate_threshold correctly returns NOT_EVALUATED instead.
Fixes #2407