Skip to content

fix: return NOT_EVALUATED for missing_percent when filter produces zero rows (#2407) #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devimano2011 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: return NOT_EVALUATED for missing_percent when filter produces zero rows (#2407) #2673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d3d848
Handle case where row count is zero in missing check
devimano2011 Apr 26, 2026
9a503d3
Fix missing_percent calculation in missing_check.py
devimano2011 Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions soda-core/src/soda_core/contracts/impl/check_types/missing_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,19 @@ def evaluate(self, measurement_values: MeasurementValues) -> CheckResult:
missing_count: int = measurement_values.get_value(self.missing_count_metric_impl)
row_count: int = measurement_values.get_value(self.row_count_metric_impl)
missing_percent: float = measurement_values.get_value(self.missing_percent_metric_impl)
if row_count == 0:
# Fix #2407: When filter removes all rows, skip the check rather than
# failing with a misleading value. There are no rows to evaluate against.
return CheckResult(
check=self,
outcome=CheckOutcome.NOT_EVALUATED,
diagnostic_metric_values={
"missing_count": missing_count,
"missing_percent": missing_percent,
"check_rows_tested": row_count,
"dataset_rows_tested": self.contract_impl.dataset_rows_tested,
},
)

diagnostic_metric_values: dict[str, float] = {
"missing_count": missing_count,
Expand Down