fix: return NOT_EVALUATED for missing_percent when filter produces zero rows (#2407)#2673
Open
devimano2011 wants to merge 2 commits into
Open
Conversation
fix: skip missing_percent check when filter produces zero rows (sodadata#2407)When a filter removes all rows (row_count=0), missing_percent was returning 0.0 which incorrectly failed checks like 'fail when < 100'. Added a guard that returns NOT_EVALUATED when row_count is 0, which is semantically correct: there are no rows to evaluate.
|
|
fix: move missing_percent assignment before row_count guard (SonarCloud)SonarCloud flagged 'missing_percent used before defined' on line 92. Fixed by moving the missing_percent assignment to before the row_count == 0 guard so all variables are defined before they are referenced.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: skip missing_percent check when filter produces zero rows (#2407)When a filter removes all rows (row_count=0), missing_percent was returning 0.0 which incorrectly failed checks like 'fail when < 100'. Added a guard that returns NOT_EVALUATED when row_count is 0, which is semantically correct: there are no rows to evaluate.
Description
Please provide a description of your changes:
Checklist