ci: fail XML lint job on errors, port helper to Python#160
Draft
gronke wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
We're down (11/14) on XSD and (1/161) on linting errors. A bug related to zpretty #161 prevents addressing the last remaining formatting issue:
After fixing the bug upstream or moving the comment (recommend this), 11 XSD schema validation issues remain: Update: Filed two upstream PRs with a fix collective/zpretty#229 and hardening collective/zpretty#230 to make future content removal get detected, not silent. |
The merged workflow reported success even when phases failed; add a Verdict step so the job goes red. Replace scripts/lint-xml.sh with scripts/lint_xml.py.
gronke
force-pushed
the
fix/ci-xml-lint-reporting
branch
from
3366f37 to
21a20c0
Compare
Replaces `pip install zpretty` with gronke/zpretty's composite action.
gronke
force-pushed
the
fix/ci-xml-lint-reporting
branch
from
21a20c0 to
60f521b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged workflow reported success even when phases failed; add a Verdict step so the job goes red. Replace scripts/lint-xml.sh with scripts/lint_xml.py.