Skip to content

docs(runtime): clarify the preset add-on lifetime comment #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mfw78 wants to merge 1 commit into from
Closed

docs(runtime): clarify the preset add-on lifetime comment #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/nexum-runtime/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,8 @@ impl<'a, R: Runtime> PresetBuilder<'a, R> {
};
let components = R::components().build::<R::Types>(&build_ctx).await?;

// The preset owns its add-ons; the launcher borrows each one to
// install it, so both the owned set and the ref view stay live across
// the launch await.
// `add_ons` owns the boxed add-ons; `add_on_refs` borrows into it and is
// consumed by the launch call, so both must stay in scope for that call.
let add_ons = R::add_ons();
let add_on_refs: Vec<&dyn RuntimeAddOn> = add_ons.iter().map(|a| &**a).collect();

Expand Down
Loading