docs(runtime): clarify the preset add-on lifetime comment#275
Closed
mfw78 wants to merge 1 commit into
Closed
Conversation
mfw78
force-pushed
the
refactor/launchcontext-touchups
branch
from
054f90d to
e37a2c3
Compare
mfw78
force-pushed
the
docs/preset-add-on-lifetime-comment
branch
from
d8044f6 to
30d9a06
Compare
mfw78
force-pushed
the
refactor/launchcontext-touchups
branch
from
e37a2c3 to
b14414e
Compare
mfw78
force-pushed
the
docs/preset-add-on-lifetime-comment
branch
from
30d9a06 to
ada8d0f
Compare
Contributor
Author
|
Superseded by the consolidated follow-up PR #278, which carries this change as a preserved commit. Closing to reduce the outstanding-PR count; the commit history is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reword the add-on lifetime comment in the preset
launchpath so it states the actual invariant:add_onsowns the boxed add-ons,add_on_refsborrows into it, and both must stay in scope for the launch call that consumes the refs.Why
Review feedback on #194 flagged the prior wording ("both ... stay live across the launch await") as imprecise: the locals drop at the end of
launch, not "across the await". The region sits in a downstream hot spot (the add-on rename car also touches these lines), so this lands as a top-of-train car rather than a mid-stack edit that would cascade-conflict across the rest of the train.Testing
Comment-only change; no code path altered.
AI Assistance: Claude Code (Opus 4.8) used for the reword and PR authoring.