Skip to content

[FIRRTL] Allow arbitrary LowerMemory dedup#10805

Open
seldridge wants to merge 3 commits into
mainfrom
dev/seldridge/firrtl-lower-memory-dedup-all
Open

[FIRRTL] Allow arbitrary LowerMemory dedup#10805
seldridge wants to merge 3 commits into
mainfrom
dev/seldridge/firrtl-lower-memory-dedup-all

Conversation

@seldridge

Copy link
Copy Markdown
Member

Remove the restriction on allowing design/ex-design deduplication of
memories in FIRRTL's LowerMemory pass. This is done to avoid problems
with unpredictable naming. It is unclear why this restriction was put on
the pass originally.

Assisted-by: pi.dev:claude-opus-4-8

Remove the restriction on allowing design/ex-design deduplication of
memories in FIRRTL's `LowerMemory` pass.  This is done to avoid problems
with unpredictable naming.  It is unclear why this restriction was put on
the pass originally.

Assisted-by: pi.dev:claude-opus-4-8
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@seldridge seldridge requested a review from darthscsi as a code owner July 9, 2026 18:17
@circt-bot

circt-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

Results of circt-tests run for a6eea91 compared to results for ab9b399:

sv-tests

Changes in emitted diagnostics:

  • +2 total change
  • +1 error: invalid operands to binary expression ('string' and 'bit[15:0]')
  • +1 error: invalid operands to binary expression ('string' and 'bit[7:0]')

seldridge added 2 commits July 9, 2026 17:33
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant