[VerifToSMT] Keep assumptions asserted across BMC timesteps#10788
Draft
leizaf wants to merge 1 commit into
Draft
[VerifToSMT] Keep assumptions asserted across BMC timesteps#10788leizaf wants to merge 1 commit into
leizaf wants to merge 1 commit into
Conversation
leizaf
force-pushed
the
lfu/bmc-assume-scope
branch
3 times, most recently
from
444a0d4 to
cb5bc74
Compare
leizaf
force-pushed
the
lfu/bmc-assume-scope
branch
from
cb5bc74 to
781ffa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-iteration pop/push in the BMC loop discarded every assertion from the previous timestep, including smt.asserts lowered from verif.assume. Checks at step i thus ignored assumptions from steps 0..i-1, yielding spurious counterexamples.
Restructure the scoping: the circuit function now asserts assumptions and definitions at the enclosing assertion level, opens a scope (push) at the end of its body, and asserts only the negated properties inside it; the loop pops that scope after each smt.check. Constraints now accumulate monotonically while property assertions stay per-step.
Assisted-by: Claude:Fable-5