[FIRRTL][InferDomains] Add option to skip checking specific domains#10763
Draft
uenoku wants to merge 1 commit into
Draft
[FIRRTL][InferDomains] Add option to skip checking specific domains#10763uenoku wants to merge 1 commit into
uenoku wants to merge 1 commit into
Conversation
f73ce85 to
49d937c
Compare
Member
Author
|
Alternative approach might be to strip specific domains as a prepass instead of suppressing individual errors, but wasn't clear which approach was better. |
09b221c to
49d937c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
-disable-domaincommand-line flag to let developers bypasserror checking for specific hardware domains (like PowerDomain).
This is necessary because it was impossible to cleanly develop or debug
an individual domain on its own. Unfinished domains would throw a flood
of validation errors and block the compiler, preventing developers from
testing the specific parts they were actively working on. This flag lets
you temporarily silence those incomplete domains.