Fixes #19 Fixes #72 duplicate subject header on windows#103
Merged
Conversation
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
weierophinney
requested changes
Aug 5, 2020
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
glensc
reviewed
Aug 6, 2020
glensc
reviewed
Aug 6, 2020
glensc
reviewed
Aug 6, 2020
glensc
reviewed
Aug 6, 2020
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
weierophinney
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
Description
Re-create zendframework/zend-mail#225 by @arueckauer Fixes #19 #72 . Original issue description reported by @matbech :
Summary
On Windows with PHP 7, when sending an mail message with the Sendmail transport, the subject header is duplicated.
Steps to reproduce
To reproduce the bug the sample from here can be used:
http://framework.zend.com/manual/current/en/modules/zend.mail.introduction.html
The resulting mail headers look something like this:
Cause
In the Sendmail transport all headers (including the Subject) and the subject itself are passed to the php mail function:
The mail function then appends to the
$subjectto the$headers. I do not think the php mail function should handle this case because it doesn't know what subject the caller intended to use. However I believe php mail should at least issue a warning (TBD: file enhancement at https://bugs.php.net/).