Merge release 2.12.2 into 2.13.x#106
Merged
weierophinney merged 11 commits intoAug 6, 2020
Merged
Conversation
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
…" conditions Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
This patch combines what was previously two test methods, `testNotSetOptionAutomaticallyOnLeadingF` and `testNotSetOptionAutomaticallyOnMiddleF`, into one method that better describes the behaviour (`testDoesNotInjectFromParameterFromSenderWhenFromOptionPresentInParameters`) and which uses a data provider to demonstrate various permutations of parameters containing a `-f` switch. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
…ad of hardcoding Smtp::class again
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
a85bd6e to
f3f69c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.12.2
2.12.2
Bug
104: Fixes #17 : Fixes when set -f option, no set -f option automatically thanks to @samsonasik
103: Fixes #19 Fixes #72 duplicate subject header on windows thanks to @samsonasik