-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Add roborock action Set Vacuum Zoned Cleaning #45686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -296,6 +296,46 @@ the specified coordinates. | |||||||||||||
| - **Description**: Y-coordinate, integer value. The dock is located at y-coordinate 25500. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
|
|
||||||||||||||
| ##### Action Set Vacuum Zoned Cleaning | ||||||||||||||
|
|
||||||||||||||
| The `roborock.set_vacuum_zoned_cleaning` action will start cleaning a | ||||||||||||||
| specified rectangular zone. | ||||||||||||||
| You can use the `roborock.get_vacuum_current_position` action to help determine | ||||||||||||||
| the coordinates for the zone. | ||||||||||||||
|
Comment on lines
+303
to
+304
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Would it be worth adding some context here about the coordinate system? |
||||||||||||||
|
|
||||||||||||||
| - **Data attribute**: `entity_id` | ||||||||||||||
| - **Description**: Only act on a specific robot. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
| - **Data attribute**: `x1` | ||||||||||||||
| - **Description**: First X-coordinate of the zone, integer value. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
| - **Data attribute**: `y1` | ||||||||||||||
| - **Description**: First Y-coordinate of the zone, integer value. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
| - **Data attribute**: `x2` | ||||||||||||||
| - **Description**: Second X-coordinate of the zone, integer value. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
| - **Data attribute**: `y2` | ||||||||||||||
| - **Description**: Second Y-coordinate of the zone, integer value. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
| - **Data attribute**: `repeats` | ||||||||||||||
| - **Description**: Number of times to clean the zone. | ||||||||||||||
| - **Optional**: No. | ||||||||||||||
|
Comment on lines
+321
to
+323
Comment on lines
+321
to
+323
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I think Copilot has a point there. Maybe something like this? Please edit if I got it wrong. |
||||||||||||||
|
|
||||||||||||||
| Example: | ||||||||||||||
|
|
||||||||||||||
| ```yaml | ||||||||||||||
| action: roborock.set_vacuum_zoned_cleaning | ||||||||||||||
| target: | ||||||||||||||
| entity_id: vacuum.roborock_s7 | ||||||||||||||
| data: | ||||||||||||||
| x1: 28582 | ||||||||||||||
| y1: 21363 | ||||||||||||||
| x2: 27425 | ||||||||||||||
| y2: 22816 | ||||||||||||||
| repeats: 0 | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Maybe change it to 1, with an explainer? |
||||||||||||||
| ``` | ||||||||||||||
|
|
||||||||||||||
| ##### Action Get Vacuum Current Position | ||||||||||||||
|
|
||||||||||||||
| The `roborock.get_vacuum_current_position` action will get the current position of the vacuum. This | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the line length limit and apply the flowing text style.