Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions source/_integrations/roborock.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,46 @@ the specified coordinates.
- **Description**: Y-coordinate, integer value. The dock is located at y-coordinate 25500.
- **Optional**: No.

##### Action Set Vacuum Zoned Cleaning

The `roborock.set_vacuum_zoned_cleaning` action will start cleaning a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the line length limit and apply the flowing text style.

specified rectangular zone.
You can use the `roborock.get_vacuum_current_position` action to help determine
the coordinates for the zone.
Comment on lines +303 to +304
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can use the `roborock.get_vacuum_current_position` action to help determine
the coordinates for the zone.
You can use the `roborock.get_vacuum_current_position` action to help determine
the coordinates for the zone. The coordinates are in the vacuum's internal map coordinate system (the same one used by `roborock.get_vacuum_current_position` and `roborock.set_vacuum_goto_position`). The dock is located near `(25500, 25500)`. `(x1, y1)` and `(x2, y2)` are two opposite corners of the rectangular zone.

Would it be worth adding some context here about the coordinate system?


- **Data attribute**: `entity_id`
- **Description**: Only act on a specific robot.
- **Optional**: No.
- **Data attribute**: `x1`
- **Description**: First X-coordinate of the zone, integer value.
- **Optional**: No.
- **Data attribute**: `y1`
- **Description**: First Y-coordinate of the zone, integer value.
- **Optional**: No.
- **Data attribute**: `x2`
- **Description**: Second X-coordinate of the zone, integer value.
- **Optional**: No.
- **Data attribute**: `y2`
- **Description**: Second Y-coordinate of the zone, integer value.
- **Optional**: No.
- **Data attribute**: `repeats`
- **Description**: Number of times to clean the zone.
- **Optional**: No.
Comment on lines +321 to +323
Comment on lines +321 to +323
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Data attribute**: `repeats`
- **Description**: Number of times to clean the zone.
- **Optional**: No.
- **Data attribute**: `repeats`
- **Description**: Number of additional times the zone cleaning is repeated. `0` cleans the zone once. Allowed values are `0`, `1`, or `2`.
- **Optional**: No.

I think Copilot has a point there. Maybe something like this? Please edit if I got it wrong.


Example:

```yaml
action: roborock.set_vacuum_zoned_cleaning
target:
entity_id: vacuum.roborock_s7
data:
x1: 28582
y1: 21363
x2: 27425
y2: 22816
repeats: 0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repeats: 0
# Clean the zone once, then repeat it one more time (two passes total).
repeats: 1

Maybe change it to 1, with an explainer?

```

##### Action Get Vacuum Current Position

The `roborock.get_vacuum_current_position` action will get the current position of the vacuum. This
Expand Down