Add roborock action Set Vacuum Zoned Cleaning#45686
Draft
Thomas55555 wants to merge 1 commit into
Draft
Conversation
home-assistant
Bot
added
has-parent
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds documentation for starting a Roborock zoned-clean action in the integration docs.
Changes:
- Documented the new
roborock.set_vacuum_zoned_cleaningaction and its required parameters. - Added a YAML example demonstrating how to call the action with coordinates and repeat count.
Comment on lines
+321
to
+323
| - **Data attribute**: `repeats` | ||
| - **Description**: Number of times to clean the zone. | ||
| - **Optional**: No. |
c0ffeeca7
requested changes
Jun 2, 2026
|
|
||
| ##### Action Set Vacuum Zoned Cleaning | ||
|
|
||
| The `roborock.set_vacuum_zoned_cleaning` action will start cleaning a |
Contributor
There was a problem hiding this comment.
Please remove the line length limit and apply the flowing text style.
Comment on lines
+321
to
+323
| - **Data attribute**: `repeats` | ||
| - **Description**: Number of times to clean the zone. | ||
| - **Optional**: No. |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Data attribute**: `repeats` | |
| - **Description**: Number of times to clean the zone. | |
| - **Optional**: No. | |
| - **Data attribute**: `repeats` | |
| - **Description**: Number of additional times the zone cleaning is repeated. `0` cleans the zone once. Allowed values are `0`, `1`, or `2`. | |
| - **Optional**: No. |
I think Copilot has a point there. Maybe something like this? Please edit if I got it wrong.
Comment on lines
+303
to
+304
| You can use the `roborock.get_vacuum_current_position` action to help determine | ||
| the coordinates for the zone. |
Contributor
There was a problem hiding this comment.
Suggested change
| You can use the `roborock.get_vacuum_current_position` action to help determine | |
| the coordinates for the zone. | |
| You can use the `roborock.get_vacuum_current_position` action to help determine | |
| the coordinates for the zone. The coordinates are in the vacuum's internal map coordinate system (the same one used by `roborock.get_vacuum_current_position` and `roborock.set_vacuum_goto_position`). The dock is located near `(25500, 25500)`. `(x1, y1)` and `(x2, y2)` are two opposite corners of the rectangular zone. |
Would it be worth adding some context here about the coordinate system?
| y1: 21363 | ||
| x2: 27425 | ||
| y2: 22816 | ||
| repeats: 0 |
Contributor
There was a problem hiding this comment.
Suggested change
| repeats: 0 | |
| # Clean the zone once, then repeat it one more time (two passes total). | |
| repeats: 1 |
Maybe change it to 1, with an explainer?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add description for Roborock zoned cleaning action
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.