Skip to content

Fix Duco mode end time sensor name#173045

Merged
jbouwh merged 1 commit into
home-assistant:devfrom
ronaldvdmeer:duco-state-end-time
Jun 5, 2026
Merged

Fix Duco mode end time sensor name#173045
jbouwh merged 1 commit into
home-assistant:devfrom
ronaldvdmeer:duco-state-end-time

Conversation

@ronaldvdmeer
Copy link
Copy Markdown
Contributor

@ronaldvdmeer ronaldvdmeer commented Jun 4, 2026

Note

If appropriate, could this follow-up Duco bugfix be included in milestone 2026.6.1? When the ventilation state sensor naming was updated, this related time_state_end sensor rename should have been included as well, but was missed.

Proposed change

This PR fixes the remaining Duco timestamp sensor name so it stays consistent with the renamed ventilation state sensor.

The time_state_end entity currently still uses Mode end time, while the related enum sensor uses Ventilation state. This follow-up renames the timestamp sensor to State end time so both entities reflect the same state model.

This should ideally be considered for the first milestone as a small bugfix follow-up. When the ventilation state sensor naming was adjusted, this companion timestamp sensor should have been renamed in the same change but was missed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR renames the Duco sensor entity "Mode end time" to "State end time" to better align the user-facing name with the underlying key time_state_end defined in strings.json.

Changes:

  • Renamed the time_state_end sensor's display name from "Mode end time" to "State end time" in the strings file.
  • Updated test snapshots to reflect the new entity name and derived entity IDs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/duco/strings.json Renames the time_state_end sensor label from "Mode end time" to "State end time".
tests/components/duco/snapshots/test_sensor.ambr Updates snapshot expectations for the renamed sensor entity, including entity_id, friendly_name, and object_id_base.

Copy link
Copy Markdown
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to include. Due to how translations work, they end up in patch releases anyway, even if they're not tagged – so we may as well include this in the release notes by tagging it.

Thanks!

Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @ronaldvdmeer 👍

@jbouwh jbouwh merged commit 291585e into home-assistant:dev Jun 5, 2026
33 checks passed
frenck pushed a commit that referenced this pull request Jun 5, 2026
@frenck frenck mentioned this pull request Jun 5, 2026
eleboucher pushed a commit to eleboucher/homelab that referenced this pull request Jun 5, 2026
…2026.6.0 ➔ 2026.6.1) (#855)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.6.0` → `2026.6.1` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary>

### [`v2026.6.1`](https://github.com/home-assistant/core/releases/tag/2026.6.1)

[Compare Source](home-assistant/core@2026.6.0...2026.6.1)

- Fix Lyric sensor crash when next\_period\_time is None ([@&#8203;bk86a] - [#&#8203;167831]) ([lyric docs])
- Fix SleepIQ 401 storm by isolating client session cookies ([@&#8203;Stormalong] - [#&#8203;172276]) ([sleepiq docs])
- Upgrade HomeLink package, set integration type ([@&#8203;rjones-gentex] - [#&#8203;172371]) ([gentex\_homelink docs][gentex_homelink docs])
- Bump actron-neo-api to 0.5.12 ([@&#8203;kclif9] - [#&#8203;172902]) ([actron\_air docs][actron_air docs]) (dependency)
- Switchbot Cloud: Fixed an issue where condition filtering for enabled Webhooks was abnormal ([@&#8203;XiaoLing-git] - [#&#8203;172903]) ([switchbot\_cloud docs][switchbot_cloud docs])
- Bump aioautomower to 2.7.6 ([@&#8203;Thomas55555] - [#&#8203;172937]) ([husqvarna\_automower docs][husqvarna_automower docs]) (dependency)
- Add more Reolink diagnostic info ([@&#8203;starkillerOG] - [#&#8203;172945]) ([reolink docs])
- Fix Mitsubishi Comfort devices skipped due to unresolved local address ([@&#8203;nikolairahimi] - [#&#8203;172959]) ([mitsubishi\_comfort docs][mitsubishi_comfort docs])
- Bump idasen-ha to 2.7.0 ([@&#8203;abmantis] - [#&#8203;172962]) ([idasen\_desk docs][idasen_desk docs]) (dependency)
- Fix value template in MQTT Fan and Siren subentry setup ([@&#8203;jbouwh] - [#&#8203;172980]) ([mqtt docs])
- Improve person tests ([@&#8203;emontnemery] - [#&#8203;172997]) ([person docs])
- Bump imgw\_pib to 2.2.2 ([@&#8203;bieniu] - [#&#8203;172999]) ([imgw\_pib docs][imgw_pib docs]) (dependency)
- Fix person in\_zones propagation from scanner in home zone ([@&#8203;emontnemery] - [#&#8203;173007]) ([person docs])
- Bump holidays to 0.98 ([@&#8203;gjohansson-ST] - [#&#8203;173029]) ([workday docs]) ([holiday docs]) (dependency)
- Portainer extend timeout for disk space coordinator ([@&#8203;erwindouna] - [#&#8203;173032]) ([portainer docs])
- Convert LinkPlay configuration\_url to string for device registry ([@&#8203;frenck] - [#&#8203;173034]) ([linkplay docs])
- Fix Duco mode end time sensor name ([@&#8203;ronaldvdmeer] - [#&#8203;173045]) ([duco docs])
- Unify query token auth in http views ([@&#8203;edenhaus] - [#&#8203;173082]) ([camera docs]) ([media\_player docs][media_player docs]) ([image docs]) ([brands docs])
- Create certificate files before trying to migrate the MQTT config entry ([@&#8203;jbouwh] - [#&#8203;173087]) ([mqtt docs])
- Bump wheels to 2026.06.0 ([@&#8203;edenhaus] - [#&#8203;173089]) (dependency)
- Bump pySmartThings to 4.0.1 ([@&#8203;joostlek] - [#&#8203;173092]) ([smartthings docs]) (dependency)
- Bump yoto-api to 3.1.6 ([@&#8203;piitaya] - [#&#8203;173104]) ([yoto docs]) (dependency)
- Bump aiostreammagic to 2.13.2 ([@&#8203;noahhusby] - [#&#8203;173114]) ([cambridge\_audio docs][cambridge_audio docs]) (dependency)
- Fix process advertisement for active scans ([@&#8203;elupus] - [#&#8203;173116]) ([bluetooth docs])

[#&#8203;167831]: home-assistant/core#167831

[#&#8203;172276]: home-assistant/core#172276

[#&#8203;172371]: home-assistant/core#172371

[#&#8203;172902]: home-assistant/core#172902

[#&#8203;172903]: home-assistant/core#172903

[#&#8203;172932]: home-assistant/core#172932

[#&#8203;172937]: home-assistant/core#172937

[#&#8203;172945]: home-assistant/core#172945

[#&#8203;172959]: home-assistant/core#172959

[#&#8203;172962]: home-assistant/core#172962

[#&#8203;172980]: home-assistant/core#172980

[#&#8203;172997]: home-assistant/core#172997

[#&#8203;172999]: home-assistant/core#172999

[#&#8203;173007]: home-assistant/core#173007

[#&#8203;173029]: home-assistant/core#173029

[#&#8203;173032]: home-assistant/core#173032

[#&#8203;173034]: home-assistant/core#173034

[#&#8203;173045]: home-assistant/core#173045

[#&#8203;173082]: home-assistant/core#173082

[#&#8203;173087]: home-assistant/core#173087

[#&#8203;173089]: home-assistant/core#173089

[#&#8203;173092]: home-assistant/core#173092

[#&#8203;173104]: home-assistant/core#173104

[#&#8203;173114]: home-assistant/core#173114

[#&#8203;173116]: home-assistant/core#173116

[@&#8203;Stormalong]: https://github.com/Stormalong

[@&#8203;Thomas55555]: https://github.com/Thomas55555

[@&#8203;XiaoLing-git]: https://github.com/XiaoLing-git

[@&#8203;abmantis]: https://github.com/abmantis

[@&#8203;bieniu]: https://github.com/bieniu

[@&#8203;bk86a]: https://github.com/bk86a

[@&#8203;edenhaus]: https://github.com/edenhaus

[@&#8203;elupus]: https://github.com/elupus

[@&#8203;emontnemery]: https://github.com/emontnemery

[@&#8203;erwindouna]: https://github.com/erwindouna

[@&#8203;frenck]: https://github.com/frenck

[@&#8203;gjohansson-ST]: https://github.com/gjohansson-ST

[@&#8203;jbouwh]: https://github.com/jbouwh

[@&#8203;joostlek]: https://github.com/joostlek

[@&#8203;kclif9]: https://github.com/kclif9

[@&#8203;nikolairahimi]: https://github.com/nikolairahimi

[@&#8203;noahhusby]: https://github.com/noahhusby

[@&#8203;piitaya]: https://github.com/piitaya

[@&#8203;rjones-gentex]: https://github.com/rjones-gentex

[@&#8203;ronaldvdmeer]: https://github.com/ronaldvdmeer

[@&#8203;starkillerOG]: https://github.com/starkillerOG

[actron_air docs]: https://www.home-assistant.io/integrations/actron_air/

[bluetooth docs]: https://www.home-assistant.io/integrations/bluetooth/

[brands docs]: https://www.home-assistant.io/integrations/brands/

[cambridge_audio docs]: https://www.home-assistant.io/integrations/cambridge_audio/

[camera docs]: https://www.home-assistant.io/integrations/camera/

[duco docs]: https://www.home-assistant.io/integrations/duco/

[gentex_homelink docs]: https://www.home-assistant.io/integrations/gentex_homelink/

[holiday docs]: https://www.home-assistant.io/integrations/holiday/

[husqvarna_automower docs]: https://www.home-assistant.io/integrations/husqvarna_automower/

[idasen_desk docs]: https://www.home-assistant.io/integrations/idasen_desk/

[image docs]: https://www.home-assistant.io/integrations/image/

[imgw_pib docs]: https://www.home-assistant.io/integrations/imgw_pib/

[linkplay docs]: https://www.home-assistant.io/integrations/linkplay/

[lyric docs]: https://www.home-assistant.io/integrations/lyric/

[media_player docs]: https://www.home-assistant.io/integrations/media_player/

[mitsubishi_comfort docs]: https://www.home-assistant.io/integrations/mitsubishi_comfort/

[mqtt docs]: https://www.home-assistant.io/integrations/mqtt/

[person docs]: https://www.home-assistant.io/integrations/person/

[portainer docs]: https://www.home-assistant.io/integrations/portainer/

[reolink docs]: https://www.home-assistant.io/integrations/reolink/

[sleepiq docs]: https://www.home-assistant.io/integrations/sleepiq/

[smartthings docs]: https://www.home-assistant.io/integrations/smartthings/

[switchbot_cloud docs]: https://www.home-assistant.io/integrations/switchbot_cloud/

[workday docs]: https://www.home-assistant.io/integrations/workday/

[yoto docs]: https://www.home-assistant.io/integrations/yoto/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants