Fix Duco mode end time sensor name#173045
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR renames the Duco sensor entity "Mode end time" to "State end time" to better align the user-facing name with the underlying key time_state_end defined in strings.json.
Changes:
- Renamed the
time_state_endsensor's display name from "Mode end time" to "State end time" in the strings file. - Updated test snapshots to reflect the new entity name and derived entity IDs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/duco/strings.json | Renames the time_state_end sensor label from "Mode end time" to "State end time". |
| tests/components/duco/snapshots/test_sensor.ambr | Updates snapshot expectations for the renamed sensor entity, including entity_id, friendly_name, and object_id_base. |
This was referenced Jun 4, 2026
TheJulianJES
approved these changes
Jun 4, 2026
jbouwh
approved these changes
Jun 5, 2026
Contributor
jbouwh
left a comment
There was a problem hiding this comment.
LGTM,
Thanks @ronaldvdmeer 👍
frenck
pushed a commit
that referenced
this pull request
Jun 5, 2026
Merged
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Jun 5, 2026
…2026.6.0 ➔ 2026.6.1) (#855) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.6.0` → `2026.6.1` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary> ### [`v2026.6.1`](https://github.com/home-assistant/core/releases/tag/2026.6.1) [Compare Source](home-assistant/core@2026.6.0...2026.6.1) - Fix Lyric sensor crash when next\_period\_time is None ([@​bk86a] - [#​167831]) ([lyric docs]) - Fix SleepIQ 401 storm by isolating client session cookies ([@​Stormalong] - [#​172276]) ([sleepiq docs]) - Upgrade HomeLink package, set integration type ([@​rjones-gentex] - [#​172371]) ([gentex\_homelink docs][gentex_homelink docs]) - Bump actron-neo-api to 0.5.12 ([@​kclif9] - [#​172902]) ([actron\_air docs][actron_air docs]) (dependency) - Switchbot Cloud: Fixed an issue where condition filtering for enabled Webhooks was abnormal ([@​XiaoLing-git] - [#​172903]) ([switchbot\_cloud docs][switchbot_cloud docs]) - Bump aioautomower to 2.7.6 ([@​Thomas55555] - [#​172937]) ([husqvarna\_automower docs][husqvarna_automower docs]) (dependency) - Add more Reolink diagnostic info ([@​starkillerOG] - [#​172945]) ([reolink docs]) - Fix Mitsubishi Comfort devices skipped due to unresolved local address ([@​nikolairahimi] - [#​172959]) ([mitsubishi\_comfort docs][mitsubishi_comfort docs]) - Bump idasen-ha to 2.7.0 ([@​abmantis] - [#​172962]) ([idasen\_desk docs][idasen_desk docs]) (dependency) - Fix value template in MQTT Fan and Siren subentry setup ([@​jbouwh] - [#​172980]) ([mqtt docs]) - Improve person tests ([@​emontnemery] - [#​172997]) ([person docs]) - Bump imgw\_pib to 2.2.2 ([@​bieniu] - [#​172999]) ([imgw\_pib docs][imgw_pib docs]) (dependency) - Fix person in\_zones propagation from scanner in home zone ([@​emontnemery] - [#​173007]) ([person docs]) - Bump holidays to 0.98 ([@​gjohansson-ST] - [#​173029]) ([workday docs]) ([holiday docs]) (dependency) - Portainer extend timeout for disk space coordinator ([@​erwindouna] - [#​173032]) ([portainer docs]) - Convert LinkPlay configuration\_url to string for device registry ([@​frenck] - [#​173034]) ([linkplay docs]) - Fix Duco mode end time sensor name ([@​ronaldvdmeer] - [#​173045]) ([duco docs]) - Unify query token auth in http views ([@​edenhaus] - [#​173082]) ([camera docs]) ([media\_player docs][media_player docs]) ([image docs]) ([brands docs]) - Create certificate files before trying to migrate the MQTT config entry ([@​jbouwh] - [#​173087]) ([mqtt docs]) - Bump wheels to 2026.06.0 ([@​edenhaus] - [#​173089]) (dependency) - Bump pySmartThings to 4.0.1 ([@​joostlek] - [#​173092]) ([smartthings docs]) (dependency) - Bump yoto-api to 3.1.6 ([@​piitaya] - [#​173104]) ([yoto docs]) (dependency) - Bump aiostreammagic to 2.13.2 ([@​noahhusby] - [#​173114]) ([cambridge\_audio docs][cambridge_audio docs]) (dependency) - Fix process advertisement for active scans ([@​elupus] - [#​173116]) ([bluetooth docs]) [#​167831]: home-assistant/core#167831 [#​172276]: home-assistant/core#172276 [#​172371]: home-assistant/core#172371 [#​172902]: home-assistant/core#172902 [#​172903]: home-assistant/core#172903 [#​172932]: home-assistant/core#172932 [#​172937]: home-assistant/core#172937 [#​172945]: home-assistant/core#172945 [#​172959]: home-assistant/core#172959 [#​172962]: home-assistant/core#172962 [#​172980]: home-assistant/core#172980 [#​172997]: home-assistant/core#172997 [#​172999]: home-assistant/core#172999 [#​173007]: home-assistant/core#173007 [#​173029]: home-assistant/core#173029 [#​173032]: home-assistant/core#173032 [#​173034]: home-assistant/core#173034 [#​173045]: home-assistant/core#173045 [#​173082]: home-assistant/core#173082 [#​173087]: home-assistant/core#173087 [#​173089]: home-assistant/core#173089 [#​173092]: home-assistant/core#173092 [#​173104]: home-assistant/core#173104 [#​173114]: home-assistant/core#173114 [#​173116]: home-assistant/core#173116 [@​Stormalong]: https://github.com/Stormalong [@​Thomas55555]: https://github.com/Thomas55555 [@​XiaoLing-git]: https://github.com/XiaoLing-git [@​abmantis]: https://github.com/abmantis [@​bieniu]: https://github.com/bieniu [@​bk86a]: https://github.com/bk86a [@​edenhaus]: https://github.com/edenhaus [@​elupus]: https://github.com/elupus [@​emontnemery]: https://github.com/emontnemery [@​erwindouna]: https://github.com/erwindouna [@​frenck]: https://github.com/frenck [@​gjohansson-ST]: https://github.com/gjohansson-ST [@​jbouwh]: https://github.com/jbouwh [@​joostlek]: https://github.com/joostlek [@​kclif9]: https://github.com/kclif9 [@​nikolairahimi]: https://github.com/nikolairahimi [@​noahhusby]: https://github.com/noahhusby [@​piitaya]: https://github.com/piitaya [@​rjones-gentex]: https://github.com/rjones-gentex [@​ronaldvdmeer]: https://github.com/ronaldvdmeer [@​starkillerOG]: https://github.com/starkillerOG [actron_air docs]: https://www.home-assistant.io/integrations/actron_air/ [bluetooth docs]: https://www.home-assistant.io/integrations/bluetooth/ [brands docs]: https://www.home-assistant.io/integrations/brands/ [cambridge_audio docs]: https://www.home-assistant.io/integrations/cambridge_audio/ [camera docs]: https://www.home-assistant.io/integrations/camera/ [duco docs]: https://www.home-assistant.io/integrations/duco/ [gentex_homelink docs]: https://www.home-assistant.io/integrations/gentex_homelink/ [holiday docs]: https://www.home-assistant.io/integrations/holiday/ [husqvarna_automower docs]: https://www.home-assistant.io/integrations/husqvarna_automower/ [idasen_desk docs]: https://www.home-assistant.io/integrations/idasen_desk/ [image docs]: https://www.home-assistant.io/integrations/image/ [imgw_pib docs]: https://www.home-assistant.io/integrations/imgw_pib/ [linkplay docs]: https://www.home-assistant.io/integrations/linkplay/ [lyric docs]: https://www.home-assistant.io/integrations/lyric/ [media_player docs]: https://www.home-assistant.io/integrations/media_player/ [mitsubishi_comfort docs]: https://www.home-assistant.io/integrations/mitsubishi_comfort/ [mqtt docs]: https://www.home-assistant.io/integrations/mqtt/ [person docs]: https://www.home-assistant.io/integrations/person/ [portainer docs]: https://www.home-assistant.io/integrations/portainer/ [reolink docs]: https://www.home-assistant.io/integrations/reolink/ [sleepiq docs]: https://www.home-assistant.io/integrations/sleepiq/ [smartthings docs]: https://www.home-assistant.io/integrations/smartthings/ [switchbot_cloud docs]: https://www.home-assistant.io/integrations/switchbot_cloud/ [workday docs]: https://www.home-assistant.io/integrations/workday/ [yoto docs]: https://www.home-assistant.io/integrations/yoto/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
If appropriate, could this follow-up Duco bugfix be included in milestone 2026.6.1? When the ventilation state sensor naming was updated, this related
time_state_endsensor rename should have been included as well, but was missed.Proposed change
This PR fixes the remaining Duco timestamp sensor name so it stays consistent with the renamed ventilation state sensor.
The
time_state_endentity currently still uses Mode end time, while the related enum sensor uses Ventilation state. This follow-up renames the timestamp sensor to State end time so both entities reflect the same state model.This should ideally be considered for the first milestone as a small bugfix follow-up. When the ventilation state sensor naming was adjusted, this companion timestamp sensor should have been renamed in the same change but was missed.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: