Fix #[var(pub)] panic during OnEditor<Gd<T>> reload#1639
Open
Bromeon wants to merge 1 commit into
Open
Conversation
The accessor registered with Godot now always goes through `GodotConvert::Via` instead of `Var::PubType`. `Via` is nullable for wrappers like `OnEditor<Gd<T>>`, so Godot-driven serialization (e.g. hot reload) reads an uninitialized field as `null` rather than panicking when unwrapping `PubType`. The Rust-facing `#[var(pub)]` accessor still uses `PubType` (may panic on uninit, by design).
Bromeon
force-pushed
the
bugfix/var-pub-hotreload
branch
from
a41c820 to
7c22d8f
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accessor registered with Godot now always goes through
GodotConvert::Viainstead ofVar::PubType.Viais nullable for wrappers likeOnEditor<Gd<T>>, so Godot-driven serialization (e.g. hot reload) reads an uninitialized field asnullrather than panicking when unwrappingPubType.The Rust-facing
#[var(pub)]accessor still usesPubType(may panic on uninit, by design).Fixes #1566.