Implement the Default trait with more specific code than the derived Default, for DuplicateFlags.#1630
Draft
rsethc wants to merge 1 commit into
Draft
Conversation
…Default, for DuplicateFlags.
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was split off from: #1627
This would be a breaking change since any code that currently uses
Default::default()and gets0, for the types which are receiving a more specific implementation here, will get something different.It will be a silently breaking change too (code that is broken by this change will likely still compile). It may be preferable to remove the derived
Default, instead of implementing it differently, so that code broken by this change catches API users' attention much more noticeably.Needs: