Rust-side Variant marshalling#1600
Draft
Bromeon wants to merge 4 commits into
Draft
Conversation
Bromeon
added
c: core
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1600 |
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
6 times, most recently
from
3a3fc71 to
c46ca24
Compare
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
from
c46ca24 to
c9bb01f
Compare
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
from
c9bb01f to
edb4f83
Compare
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
2 times, most recently
from
05e0e45 to
534abfc
Compare
Marks Variant types that *must* be constructed/destroyed via FFI.
`Extend` pre-allocates from the iterator's size hint, removing per-element grow overhead. The hint is a lower bound only: an over-reporting iterator appends what it yields and trims unused trailing slots instead of panicking. `resize_default` complements `resize()` for default-constructible types needing no explicit fill value.
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
from
534abfc to
eeebe71
Compare
POD builtin types (numbers, vectors, color, RID) marshal directly into/from Variant's raw memory layout, skipping Godot FFI for both value conversion and lifecycle (clone, drop, default). The `variant-ffi-marshal` feature restores the FFI path for A/B benchmarking. Tests and benchmarks verify both the round-trip correctness and cross-FFI layout agreement (Godot-created variants decoded by `RustVariant` view and vice versa).
Bromeon
force-pushed
the
perf/variant-rust-marshal
branch
from
eeebe71 to
e0aefc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
VariantholdingCopybuiltin types (or rather those that don't need an FFI constructor/destructor), we can emulate Godot'sVariantlayout directly in Rust. This saves a large number of FFI calls for justVariantconversions and has the potential to speed up operations across the board.