Skip to content

Synchronize mutations to DB connections #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seadowg wants to merge 1 commit into
base: v2026.3.x
Choose a base branch
from
+16 −12
Open

Synchronize mutations to DB connections #7314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions db/src/main/java/org/odk/collect/db/sqlite/DatabaseConnection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,27 +109,31 @@ open class DatabaseConnection @JvmOverloads constructor(

@JvmStatic
fun cleanUp() {
val openHelpersToClear = mutableListOf<String>()
synchronized(openHelpers) {
val openHelpersToClear = mutableListOf<String>()

openHelpers.forEach { (databasePath, openHelper) ->
if (!File(databasePath).exists()) {
openHelper.close()
openHelpersToClear.add(databasePath)
openHelpers.forEach { (databasePath, openHelper) ->
if (!File(databasePath).exists()) {
openHelper.close()
openHelpersToClear.add(databasePath)
}
}
}

openHelpersToClear.forEach {
openHelpers.remove(it)
openHelpersToClear.forEach {
openHelpers.remove(it)
}
}
}

@JvmStatic
fun closeAll() {
openHelpers.forEach { (_, openHelper) -> openHelper.close() }
openHelpers.clear()
synchronized(openHelpers) {
openHelpers.forEach { (_, openHelper) -> openHelper.close() }
openHelpers.clear()

toClose.forEach(SQLiteOpenHelper::close)
toClose.clear()
toClose.forEach(SQLiteOpenHelper::close)
toClose.clear()
}
}
}
}
Expand Down