Skip to content

Synchronize mutations to DB connections#7314

Open
seadowg wants to merge 1 commit into
getodk:v2026.3.xfrom
seadowg:db-helper
Open

Synchronize mutations to DB connections#7314
seadowg wants to merge 1 commit into
getodk:v2026.3.xfrom
seadowg:db-helper

Conversation

@seadowg

@seadowg seadowg commented Jul 20, 2026

Copy link
Copy Markdown
Member

Potentially address this crash report.

Why is this the best possible solution? Were any other approaches considered?

It definitely seemed like we shouldn't allow multiple threads to access cleanUp or closeAll so whether this is a fix for the crash or not, I think it's a good change.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Good to play around with changing and deleting projects as that's the only time we destroy database connections in the app.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg
seadowg changed the base branch from master to v2026.3.x July 20, 2026 11:06
@seadowg
seadowg marked this pull request as ready for review July 20, 2026 12:00
@seadowg
seadowg requested a review from grzesiek2010 July 20, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants