Add Google Chat notification handler; Allow more than one handler to be used at a time; Fix MS teams notification test; Fix failing GitHub build; Prevent a job from failing when coverage step fails;

[Kosma Grochowski (kosmag)]

Add feature - Google Chat notification handler
Resolve bug - allow more than one notification handler to be used at a time
Resolve bug - fix MS Teams notification test
Resolve bug - fix failing build pipeline, prevent pipeline from failing when a coverage step fails

[Dominik Gniewek-Węgrzyn (dgniewek)]

LGTMT

[Dominik Gniewek-Węgrzyn (dgniewek)]

Code review

Found 3 issues:

1. Inconsistent template variable naming - The Google Chat handler uses different variable names ({task_id}, {dag_id}, {execution_date}, {log_url}) compared to Slack and MS Teams handlers ({task}, {dag}, {execution_time}, {url}). Since this PR enables multiple handlers to run simultaneously, users will need to maintain different template formats for different notification types.

dbt-airflow-factory/dbt_airflow_factory/notifications/handler.py

Lines 88 to 94 in 72ecc2b

	message_text = handler_definition["message_template"].format(
	task_id=task_id,
	dag_id=dag_id,
	execution_date=context.get("execution_date"),
	log_url=logs_url,
	)

Compare with Slack handler:

dbt-airflow-factory/dbt_airflow_factory/notifications/handler.py

Lines 35 to 40 in 72ecc2b

	message=handler_definition["message_template"].format(
	task=context.get("task_instance").task_id,
	dag=context.get("task_instance").dag_id,
	execution_time=context.get("execution_date"),
	url=context.get("task_instance").log_url,
	),

2. Google Chat test has inadequate verification - The test only verifies that HttpHook was instantiated (mock_http_hook.assert_called_once()), but doesn't verify that the .run() method was called with the correct data, headers, or connection ID. This provides significantly less coverage than the Slack and MS Teams tests.

dbt-airflow-factory/tests/test_notifications.py

Lines 163 to 166 in 72ecc2b

	factory.create_failure_handler(notifications_config)(context)
	# then
	mock_http_hook.assert_called_once()

Compare with MS Teams test pattern (lines 87-107) which properly verifies the webhook call details.

3. Test doesn't verify HttpHook.run() was actually called - The mock is on the HttpHook class itself, not the .run() method. The test would pass even if the code was changed to just instantiate HttpHook without calling .run(). Consider mocking HttpHook.run and verifying it was called with the expected JSON data and headers.

dbt-airflow-factory/tests/test_notifications.py

Lines 153 to 166 in 72ecc2b

	@patch("dbt_airflow_factory.notifications.handler.HttpHook")
	def test_notification_send_for_google_chat(mock_http_hook, mock_get_connection):
	# given
	notifications_config = AirflowDagFactory(
	path.dirname(path.abspath(__file__)), "notifications_google_chat"
	).airflow_config["failure_handlers"]
	factory = NotificationHandlersFactory()
	context = create_context()
	mock_get_connection.return_value = create_google_chat_connection()
	# when
	factory.create_failure_handler(notifications_config)(context)
	# then
	mock_http_hook.assert_called_once()

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[Kosma Grochowski (kosmag)]

Dominik Gniewek-Węgrzyn (@dgniewek) All fixed

[Dominik Gniewek-Węgrzyn (dgniewek)]

Updated Code Review

Thanks for addressing the feedback! All 3 issues have been successfully fixed:

✅ Template variable naming consistency - Now uses {task}, {dag}, {execution_time}, {url} matching Slack/MS Teams
✅ Test properly mocks HttpHook.run - Using @patch on the .run() method directly
✅ Test verifies the webhook call - Includes mock_run.assert_called_once() and validates payload

All requested changes have been addressed. The implementation looks good!

🤖 Generated with Claude Code