Fix issues according to code review

Author: Kosma Grochowski

dbt_airflow_factory/notifications/handler.py

@@ -87,10 +87,10 @@ def failure_handler(context: Any) -> None:
                     logs_url = f"{webserver_url}/{query}"
 
                     message_text = handler_definition["message_template"].format(
-                        task_id=task_id,
-                        dag_id=dag_id,
-                        execution_date=context.get("execution_date"),
-                        log_url=logs_url,
+                        task=task_id,
+                        dag=dag_id,
+                        execution_time=context.get("execution_date"),
+                        url=logs_url,
                     )
                     message_body = {"text": message_text}
 

tests/config/notifications_google_chat/airflow.yml

@@ -5,7 +5,7 @@ failure_handlers:
     connection_id: google_chat_failure
     message_template: |
         🔴 *Task Failed*
-        *Task*: {task_id}
-        *Dag*: {dag_id}
-        *Execution Time*: {execution_date}
-        *Log Url*: {log_url}
+        *Task*: {task}
+        *Dag*: {dag}
+        *Execution Time*: {execution_time}
+        *Log Url*: {url}

tests/google_chat_expected_data.txt

@@ -0,0 +1,5 @@
+🔴*TaskFailed*
+*Task*:task_id
+*Dag*:dag_id
+*ExecutionTime*:somedate
+*LogUrl*:https://your.airflow-webserver.url/log?dag_id=dag_id&task_id=task_id&execution_date=ts

tests/test_notifications.py

@@ -150,8 +150,8 @@ def create_context():
     if IS_AIRFLOW_NEWER_THAN_2_4
     else "airflow.hooks.base_hook.BaseHook.get_connection"
 )
-@patch("dbt_airflow_factory.notifications.handler.HttpHook")
-def test_notification_send_for_google_chat(mock_http_hook, mock_get_connection):
+@patch("dbt_airflow_factory.notifications.handler.HttpHook.run")
+def test_notification_send_for_google_chat(mock_run, mock_get_connection):
     # given
     notifications_config = AirflowDagFactory(
         path.dirname(path.abspath(__file__)), "notifications_google_chat"
@@ -163,4 +163,10 @@ def test_notification_send_for_google_chat(mock_http_hook, mock_get_connection):
     factory.create_failure_handler(notifications_config)(context)
 
     # then
-    mock_http_hook.assert_called_once()
+    request = mock_run.call_args_list[0].kwargs
+    mock_run.assert_called_once()
+
+    actual_request_data = json.loads(request["data"].replace("\n", "").replace(" ", ""))
+    expected_request_data_path = pathlib.Path(__file__).parent / "google_chat_expected_data.txt"
+    expected_request_data_text = pathlib.Path(expected_request_data_path).read_text()
+    assert actual_request_data['text'] == expected_request_data_text