Skip to content

Make the TypeScript code depend on the publish argon2id-wasm package - #393

Merged
Nicolapps merged 1 commit into
rebootfrom
nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package
Jul 10, 2026
Merged

Make the TypeScript code depend on the publish argon2id-wasm package#393
Nicolapps merged 1 commit into
rebootfrom
nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package

Conversation

@Nicolapps

Copy link
Copy Markdown
Member

This makes sure we don’t need to build the Rust code when making TS-only changes.

@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
convex-auth-docs Ignored Ignored Jul 10, 2026 7:04pm

Request Review

@github-actions

Copy link
Copy Markdown

⚠️ This PR modifies the Rust code.

For these changes to take effect in the TypeScript code, you will need to:

  1. Publish a new version of the argon2id-wasm package on npm.
  2. Update the dependency on argon2id-wasm in the core component.

@Nicolapps
Nicolapps force-pushed the nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package branch 2 times, most recently from 16b5400 to 1060802 Compare July 10, 2026 15:20
@Nicolapps
Nicolapps changed the base branch from nicolas/fix_argon2-wasm_npm_packing to graphite-base/393 July 10, 2026 16:10
@Nicolapps
Nicolapps force-pushed the nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package branch from 1060802 to 41a9d45 Compare July 10, 2026 16:10
@Nicolapps
Nicolapps changed the base branch from graphite-base/393 to nicolas/fix_structure_of_argon2id-wasm_package July 10, 2026 16:10
@Nicolapps
Nicolapps force-pushed the nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package branch 4 times, most recently from e4057b8 to a751bd2 Compare July 10, 2026 16:29
@Nicolapps
Nicolapps force-pushed the nicolas/fix_structure_of_argon2id-wasm_package branch from 6605763 to 26b31fd Compare July 10, 2026 16:29
@Nicolapps
Nicolapps marked this pull request as ready for review July 10, 2026 16:31
@Nicolapps
Nicolapps force-pushed the nicolas/fix_structure_of_argon2id-wasm_package branch from 26b31fd to 7d1d994 Compare July 10, 2026 17:50
@Nicolapps
Nicolapps force-pushed the nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package branch 2 times, most recently from 5998056 to b9c25da Compare July 10, 2026 18:16
@Nicolapps
Nicolapps force-pushed the nicolas/fix_structure_of_argon2id-wasm_package branch 2 times, most recently from 0a006d9 to ed5b16d Compare July 10, 2026 18:19
@Nicolapps
Nicolapps force-pushed the nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package branch from b9c25da to 56c4dc0 Compare July 10, 2026 18:19

Nicolapps commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Merge activity

  • Jul 10, 6:36 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 10, 7:05 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 10, 7:07 PM UTC: @Nicolapps merged this pull request with Graphite.

@Nicolapps
Nicolapps changed the base branch from nicolas/fix_structure_of_argon2id-wasm_package to graphite-base/393 July 10, 2026 19:00
@Nicolapps
Nicolapps changed the base branch from graphite-base/393 to reboot July 10, 2026 19:03
This makes sure we don’t need to build the Rust code when making TS-only changes.
@Nicolapps
Nicolapps force-pushed the nicolas/make_the_typescript_code_depend_on_the_publish_argon2id-wasm_package branch from 56c4dc0 to fe1199b Compare July 10, 2026 19:04
@Nicolapps
Nicolapps merged commit fcc3c10 into reboot Jul 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant