Password provider: setupUsernamePassword - #383
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 8, 2026 22:52
de07136 to
db808a3
Compare
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 9, 2026 16:55
db808a3 to
1b0f630
Compare
Nicolapps
changed the base branch from
graphite-base/383
to
nicolas/auth-core-get-user-id-by-account
July 9, 2026 16:55
Nicolapps
commented
Jul 9, 2026
| * The provider function that completes an authentication flow should | ||
| * call this function when it has authenticated an account and return | ||
| * the result. | ||
| * It will be passed a {@link ProviderHelpers} bundle, provided by Convex |
Member
Author
There was a problem hiding this comment.
Claude decided to change the parameters of the provider function in order to make it work. I don't feel great about it and I wonder if it would make more sense for providers to only receive a reference to the core component.
Contributor
There was a problem hiding this comment.
I don't mind the param change that much, and I like providing something more specific than the whole component for clarity.
Maybe we'll find that we're just repackaging the core component API and it makes sense to just collapse it back to that, but this seems fine for now.
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
2 times, most recently
from
July 9, 2026 17:25
0427738 to
e543b5f
Compare
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 9, 2026 18:21
e543b5f to
eb69f5a
Compare
Nicolapps
changed the base branch from
nicolas/auth-core-get-user-id-by-account
to
graphite-base/383
July 9, 2026 18:25
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 9, 2026 22:17
eb69f5a to
6d8c361
Compare
Nicolapps
changed the base branch from
graphite-base/383
to
nicolas/auth-core-get-user-id-by-account
July 9, 2026 22:17
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
2 times, most recently
from
July 9, 2026 22:53
1474d71 to
dc12859
Compare
Nicolapps
commented
Jul 9, 2026
| // so this call should not fail. | ||
| // Throwing so that the transaction doesn’t commit. | ||
| // | ||
| // TODO(nicolas) can we improve this? |
Member
Author
There was a problem hiding this comment.
I kind of want to change setPassword to succeed or throw a Error, and ask from the caller that they run input validation first, to make sure we don't need to revert the user creation
Nicolapps
marked this pull request as ready for review
July 9, 2026 22:57
Nicolapps
changed the base branch from
nicolas/auth-core-get-user-id-by-account
to
graphite-base/383
July 9, 2026 23:48
This was referenced Jul 9, 2026
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 10, 2026 15:58
dc12859 to
d1a1053
Compare
Nicolapps
force-pushed
the
graphite-base/383
branch
from
July 10, 2026 15:58
1699777 to
aed7187
Compare
Nicolapps
changed the base branch from
graphite-base/383
to
nicolas/auth-core-get-user-id-by-account
July 10, 2026 15:58
Nicolapps
changed the base branch from
nicolas/auth-core-get-user-id-by-account
to
graphite-base/383
July 10, 2026 16:00
dowski
approved these changes
Jul 10, 2026
| * The provider function that completes an authentication flow should | ||
| * call this function when it has authenticated an account and return | ||
| * the result. | ||
| * It will be passed a {@link ProviderHelpers} bundle, provided by Convex |
Contributor
There was a problem hiding this comment.
I don't mind the param change that much, and I like providing something more specific than the whole component for clarity.
Maybe we'll find that we're just repackaging the core component API and it makes sense to just collapse it back to that, but this seems fine for now.
Member
Author
Nicolapps
changed the base branch from
graphite-base/383
to
nicolas/auth-core-get-user-id-by-account
July 10, 2026 17:44
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 10, 2026 17:50
2073301 to
94dee2c
Compare
Nicolapps
changed the base branch from
nicolas/auth-core-get-user-id-by-account
to
graphite-base/383
July 10, 2026 18:16
Member
Author
Merge activity
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Nicolapps
force-pushed
the
nicolas/auth-password-setup-function
branch
from
July 10, 2026 18:37
94dee2c to
b29a8a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.