test(pubsub): lower flaky high-volume test to 500 messages#2766
Conversation
test_high_volume_messages is an acceptance test, not a benchmark, and 5k messages made it flaky. Drop to 500 to keep it stable while still verifying no messages are lost under moderate volume.
Greptile SummaryThis PR reduces the flaky pubsub high-volume test size.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into fix/ivan/flakey..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2766 +/- ##
==========================================
- Coverage 72.08% 72.07% -0.01%
==========================================
Files 941 941
Lines 84224 84224
Branches 7650 7650
==========================================
- Hits 60709 60706 -3
- Misses 21472 21473 +1
- Partials 2043 2045 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
spomichter
left a comment
There was a problem hiding this comment.
Approving since change makes sense but also unsure what the test does and hard coding 5k messages seems arbitrary as we move to more transports.
Thinking was for a local transport if you cannot exchange 5k small messages it's not a functional transport |
test_high_volume_messages was flakey