feat(transport): rust zenoh support and api refactor#2753
Open
aclauer wants to merge 15 commits into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Greptile SummaryThis PR adds Zenoh support and refactors native-module transport handling. The main changes are:
Confidence Score: 4/5This is close, but the LCM receive path should be fixed before merging.
native/rust/dimos-module/src/lcm.rs Important Files Changed
Reviews (4): Last reviewed commit: "Precommit please" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I swear it's not actually 18k lines, most of that is Cargo.lock
Note: currently don't have QoS, that needs to be added later
Closes DIM-XXX
Solution
How to Test
local ping pong
remote ping pong (run on different machines, connected to same network)
benchmark between lcm and zenoh locally
Contributor License Agreement