Skip to content

tmt: drop kola-testiso plan and associated test cases #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roshan-R merged 1 commit into from
May 18, 2026
+2 −34
Merged

tmt: drop kola-testiso plan and associated test cases #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tmt/plans/main.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,3 @@ execute:
- init
- build-qemu
- test-kola-upgrade

/kola-testiso:
summary: run kola testiso tests
discover+:
how: fmf
test:
- init
- build-iso
- test-iso
2 changes: 0 additions & 2 deletions tmt/tests/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,4 @@ source "utils.sh"

if [ "$TEST_CASE" = "build-qemu" ]; then
cosa osbuild qemu
elif [ "$TEST_CASE" = "build-iso" ]; then
cosa osbuild live metal metal4k
fi
Comment on lines 7 to 9

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the removal of the build-iso case, this conditional check is now redundant. The entrypoint.sh script already ensures that build.sh is only invoked when TEST_CASE is build-qemu. Simplifying this to a direct command improves readability and maintains consistency with other scripts like init.sh.

Suggested change
if [ "$TEST_CASE" = "build-qemu" ]; then
cosa osbuild qemu
elif [ "$TEST_CASE" = "build-iso" ]; then
cosa osbuild live metal metal4k
fi
cosa osbuild qemu

4 changes: 2 additions & 2 deletions tmt/tests/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ case "$TEST_CASE" in
"init")
./init.sh
;;
"build-qemu"|"build-iso")
"build-qemu")
./build.sh
;;
"test-qemu"|"test-kola-upgrade"|"test-iso")
"test-qemu"|"test-kola-upgrade")
./test.sh
;;
*)
Expand Down
12 changes: 0 additions & 12 deletions tmt/tests/kola.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,3 @@ test: ./entrypoint.sh
order: 80
environment:
TEST_CASE: test-kola-upgrade

/build-iso:
duration: 1h
order: 90
environment:
TEST_CASE: build-iso

/test-iso:
duration: 2h
order: 100
environment:
TEST_CASE: test-iso
9 changes: 0 additions & 9 deletions tmt/tests/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,4 @@ elif [ "$TEST_CASE" = "test-kola-upgrade" ]; then
)
run_kola
collect_kola_artifacts

elif [ "$TEST_CASE" = "test-iso" ]; then
export KOLA_ACTION="testiso"
export KOLA_ID="test-iso"
export KOLA_EXTRA_ARGS=(
--inst-insecure
)
run_kola
collect_kola_artifacts
fi