tmt: drop kola-testiso plan and associated test cases#1350
Merged
Conversation
`kola run` now handles all ISO test scenarios, making the dedicated `kola testiso` tmt plan, build steps, and test cases unnecessary. See: coreos/coreos-assembler#4377
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes ISO-related build and test configurations from the TMT test suite, including the main plan, test definitions, and execution scripts. A review comment suggests simplifying the build script by removing a redundant conditional check, as the entry point already ensures the correct test case is executed.
Comment on lines
7
to
9
| if [ "$TEST_CASE" = "build-qemu" ]; then | ||
| cosa osbuild qemu | ||
| elif [ "$TEST_CASE" = "build-iso" ]; then | ||
| cosa osbuild live metal metal4k | ||
| fi |
There was a problem hiding this comment.
With the removal of the build-iso case, this conditional check is now redundant. The entrypoint.sh script already ensures that build.sh is only invoked when TEST_CASE is build-qemu. Simplifying this to a direct command improves readability and maintains consistency with other scripts like init.sh.
Suggested change
| if [ "$TEST_CASE" = "build-qemu" ]; then | |
| cosa osbuild qemu | |
| elif [ "$TEST_CASE" = "build-iso" ]; then | |
| cosa osbuild live metal metal4k | |
| fi | |
| cosa osbuild qemu |
joelcapitao
approved these changes
May 18, 2026
jbtrystram
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kola runnow handles all ISO test scenarios, making the dedicatedkola testisotmt plan, build steps, and test cases unnecessary.See: coreos/coreos-assembler#4377