Fix traffic light snapshots outside junctions - #9853
Open
timothyanderson096-ocdealcheck wants to merge 2 commits into
Open
Fix traffic light snapshots outside junctions#9853timothyanderson096-ocdealcheck wants to merge 2 commits into
timothyanderson096-ocdealcheck wants to merge 2 commits into
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Contributor
|
Hey, we are truly sorry about the delay; Please, target ue58-dev |
timothyanderson096-ocdealcheck
force-pushed
the
fix-9832-traffic-light-group
branch
from
September 2, 2026 00:03
f393de7 to
bd7e978
Compare
Register fallback traffic-light controllers through the group API so they receive their owning group. Add a smoke regression covering OpenDRIVE traffic lights outside junctions and their client snapshot state. Co-authored-by: Codex <codex@openai.com>
timothyanderson096-ocdealcheck
force-pushed
the
fix-9832-traffic-light-group
branch
from
September 2, 2026 00:04
bd7e978 to
6a52e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standalone OpenDRIVE traffic lights use a fallback controller-registration path when their controller is not associated with a junction. That path appended the controller directly to the group's controller array, bypassing
ATrafficLightGroup::AddController()and itsController->SetGroup(this)call.Without the owning group,
WorldObserveremits a zero-initialized client snapshot: the state appears permanently Red, the OpenDRIVE signal ID is empty, and all phase timings are zero even though the server-side component accepts state changes.This change:
ATrafficLightGroup::AddController()Fixes #9832
Where has this been tested?
git diff --checkThe regression uses the issue reporter's runtime-proven minimal fixture and is intended to be exercised against the UE5 server by the upstream smoke-test environment.
Possible Drawbacks
The smoke suite now generates one additional minimal OpenDRIVE world, adding some runtime. The production behavior change is limited to fallback traffic-light controllers and gives them the same group registration used by the normal controller path.
This change is