Add new signals for appending sequencer table#1159
Draft
LuisFSegalla wants to merge 4 commits into
Draft
Conversation
hyperrealist
left a comment
hyperrealist
left a comment
Collaborator
There was a problem hiding this comment.
See comment below.
coretl
requested changes
Dec 10, 2025
|
|
||
| REPLACE = "Replace" | ||
| APPEND = "Append" | ||
| LAST = "Append Last" |
Collaborator
There was a problem hiding this comment.
Suggested change
| LAST = "Append Last" | |
| APPEND_LAST = "Append Last" |
Comment on lines
+120
to
+122
| clear_table: SignalW[PandaSeqClear] | None | ||
| seq_write: SignalW[PandaSeqWrite] | None | ||
| queued_lines: SignalR[PandaSeqQueued] | None |
Collaborator
There was a problem hiding this comment.
These are all attributes of SEQ1.TABLE, so FastCS should create Attrs that have PVs and PVI names that begin with table. Please can you use the names from the issue.
coretl
reviewed
Dec 11, 2025
Comment on lines
99
to
102
coretl
reviewed
Dec 11, 2025
| queued_lines: SignalR[PandaSeqQueued] | None | ||
| table_clear: SignalX | None | ||
| table_next_write: SignalW[PandaSeqWrite] | None | ||
| table_queued_lines: SignalR[PandaSeqQueued] | None |
Collaborator
There was a problem hiding this comment.
This should be SignalR[int] | None
coretl
reviewed
Dec 11, 2025
coretl
reviewed
Dec 11, 2025
LuisFSegalla
force-pushed
the
1148-add-table-appending-records-for-panda
branch
from
729569a to
5f61b4a
Compare
coretl
approved these changes
Dec 12, 2025
coretl
left a comment
coretl
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks right
LuisFSegalla
force-pushed
the
1148-add-table-appending-records-for-panda
branch
from
5f61b4a to
921c8fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1148