Skip to content

fix: update default maxlen for ScanStorage to 10 #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wakonig merged 1 commit into from
Jun 17, 2026
+5 −5
Merged

fix: update default maxlen for ScanStorage to 10 #961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bec_lib/bec_lib/scan_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,11 @@ class ScanStorage:

Args:
scan_manager: The scan manager that will use this storage.
maxlen: Maximum number of scan items to store (default: 100).
maxlen: Maximum number of scan items to store (default: 10).
init_scan_number: Initial scan number to start from (default: 0).
"""

def __init__(self, scan_manager: ScanManager, maxlen=100, init_scan_number=0) -> None:
def __init__(self, scan_manager: ScanManager, maxlen=10, init_scan_number=0) -> None:
self.scan_manager = scan_manager
self.storage = deque(maxlen=maxlen)
self.last_scan_number = init_scan_number
Expand Down Expand Up @@ -504,7 +504,7 @@ def update_with_queue_status(self, queue_msg: messages.ScanQueueStatusMessage):

This method is thread-safe and processes queue status messages to create ScanItem
instances for any scans that don't already exist in storage. It limits processing
to the most recent 20 queue items to avoid excessive memory usage.
to the most recent 5 queue items to avoid excessive memory usage.

Args:
queue_msg(messages.ScanQueueStatusMessage): The queue status message containing scan info.
Expand All @@ -526,7 +526,7 @@ def update_with_queue_status(self, queue_msg: messages.ScanQueueStatusMessage):
scan_id=queue_item.scan_id[scan_idx], # type: ignore[index]
status=queue_item.status, # type: ignore[attr-defined]
)
if ii > 20:
# only keep the last 20 queue items in storage to avoid
if ii > 5:
# only keep the last 5 queue items in storage to avoid
# evicting too many items just because of a large queue
break
Loading