fix: update default maxlen for ScanStorage to 3#961
Open
wakonig wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces in-memory retention for ScanStorage by lowering the default maximum number of stored ScanItems, relying on history retrieval for older scans.
Changes:
- Update
ScanStoragedefaultmaxlenfrom 100 to 3. - Align the
ScanStoragedocstring to reflect the new default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """ | ||
|
|
||
| def __init__(self, scan_manager: ScanManager, maxlen=100, init_scan_number=0) -> None: | ||
| def __init__(self, scan_manager: ScanManager, maxlen=3, init_scan_number=0) -> None: |
| """ | ||
|
|
||
| def __init__(self, scan_manager: ScanManager, maxlen=100, init_scan_number=0) -> None: | ||
| def __init__(self, scan_manager: ScanManager, maxlen=3, init_scan_number=0) -> None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It should be enough to keep the last 3 elements in memory. Everything else can be fetched from the bec history.