Skip to content

[Testing with dev env] Remove guard for scrollToRevealElement argument #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tombye wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Testing with dev env] Remove guard for scrollToRevealElement argument #5937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/assets/javascripts/esm/stick-to-window-when-scrolling.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,9 +664,6 @@ class StickAtEdge {

// Public method to scroll so an element isn't covered by the sticky nav
scrollToRevealElement ($el) {
// guard against previous version of this method recieving `$el` as a jQuery-wrapped DOM node
if ('jquery' in $el) { $el = $el.get(0); }

const scrollAreaNode = $el.closest('.sticky-scroll-area');
const matches = scrollAreas.filterBy(scrollArea => {
return scrollArea.node === scrollAreaNode;
Expand Down
Loading