[Testing with dev env] Remove guard for scrollToRevealElement argument#5937
Draft
tombye wants to merge 1 commit into
Draft
[Testing with dev env] Remove guard for scrollToRevealElement argument#5937tombye wants to merge 1 commit into
tombye wants to merge 1 commit into
Conversation
We removed all the uses of jQuery in this pull request: #5924 But the scrollToRevealElement method is used by some JS script in the functional tests, and still sent the argument in (a DOM node) wrapped in a jQuery object. We added a guard when we changed the code, to deal with this use, but the code doing that was changed in this pull request: alphagov/notifications-functional-tests#657 ...so we no longer need the guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed all the uses of jQuery in this pull
request:
#5924
But the scrollToRevealElement method is used by
some JS script in the functional tests, and still
sent the argument in (a DOM node) wrapped in a
jQuery object. We added a guard when we changed
the code, to deal with this use, but the code
doing that was changed in this pull request:
alphagov/notifications-functional-tests#657
...so we no longer need the guard.