Conversation
|
Build successful! 🎉 |
LFDanLu
commented
Jun 12, 2026
| // for that case we want to avoid reporting size 0 otherwise we get into a state | ||
| // where the virtualizer renders 0 items when it is hidden and thus won't remeasure when it is is unhidden | ||
| // in jsdom tests, offsetParent can be null, so skip the check there. | ||
| if (!navigator.userAgent.includes('jsdom') && ref.current.offsetParent === null) { |
Member
Author
There was a problem hiding this comment.
will need to think about this check since jsdom is probably not the only one used in tests
Contributor
There was a problem hiding this comment.
Maybe check isElementVisible() instead? This will inherit display and should work in test environments.
nwidynski
reviewed
Jun 12, 2026
| export default defineConfig({ | ||
| define: { | ||
| // make sure virtualizer actually runs since this is in browser | ||
| 'process.env.VIRT_ON': '"1"' |
Contributor
There was a problem hiding this comment.
Isnt VIRT_ON only relevant for test environments? This is to say, why are the browser tests using the test environment instead of dev or prod?
A bunch of logic behind the test flag is tailored around JDOM and synthetic event quirks etc, which are not applicable to CDP and a real browser.
Member
Author
There was a problem hiding this comment.
oh fair point, didn't really consider that but makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10171
✅ Pull Request Checklist:
📝 Test Instructions:
Test the "Virtualized Display None Toggle" gridlist story, the gridlist's items shouldn't disappear even when toggled a bunch
🧢 Your Project:
RSP