Skip to content

[19.0][FIX] Auditlog: Maximum recursion error when creating new accounts #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hi-oerp wants to merge 1 commit into
base: 19.0
Choose a base branch
from
+9 −1
Open

[19.0][FIX] Auditlog: Maximum recursion error when creating new accounts #3646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion auditlog/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
Audit Log
=========

..
..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
Expand Down Expand Up @@ -124,6 +124,9 @@ Contributors
- Bogdan Valentin Gabor <valentin.gabor@bt-group.com>
- Dennis Sluijk d.sluijk@onestein.nl
- Adam Heinz <adam.heinz@metricwise.com>
- `OERP Canada <https://www.oerp.ca/>`__:

- Hembert Iregui <hi@oerp.ca>

Other credits
-------------
Expand Down
5 changes: 5 additions & 0 deletions auditlog/models/auditlog_rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,9 @@ def _make_write(self):
users_to_exclude = self.mapped("users_to_exclude_ids")

def write_full(self, vals, **kwargs):
if self.env.context.get("auditlog_disabled"):
return write_full.origin(self, vals, **kwargs)

self = self.with_context(auditlog_disabled=True)
rule_model = self.env["auditlog.rule"]
fields_list = rule_model.get_auditlog_fields(self)
Expand Down Expand Up @@ -503,6 +506,8 @@ def write_full(self, vals, **kwargs):
return result

def write_fast(self, vals, **kwargs):
if self.env.context.get("auditlog_disabled"):
return write_fast.origin(self, vals, **kwargs)
self = self.with_context(auditlog_disabled=True)
rule_model = self.env["auditlog.rule"]
# Log the user input only, no matter if the `vals` is updated
Expand Down
Loading