[19.0][FIX] Auditlog: Maximum recursion error when creating new accounts#3646
Open
hi-oerp wants to merge 1 commit into
Open
[19.0][FIX] Auditlog: Maximum recursion error when creating new accounts#3646hi-oerp wants to merge 1 commit into
hi-oerp wants to merge 1 commit into
Conversation
0567677 to
9f5f4c1
Compare
9f5f4c1 to
171695d
Compare
Author
|
Good morning. @sebalix @StefanRijnhart @pedrobaeza @hbrunn Could you please help me validate this so we can proceed with the approval and merge? Thanks! |
StefanRijnhart
left a comment
Member
There was a problem hiding this comment.
Thanks! Can you add a reproducing test to https://github.com/OCA/server-tools/tree/19.0/test_auditlog?
Member
|
If you check the failing tests, it looks like your changes prevent some other expected logs to be created, so it's not all well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module
Auditlog
Describe the bug
Maximum recursion error when creating new accounts
To Reproduce
Create a new rule for the account.account module
Check "Log Creates", "Log Writes" and "Full Log" in the new rule
Steps to reproduce the behavior:
Go to Accounting -> Configuration -> Chart of Account
Create a new account with code
Foreve loading and "RecursionError: maximum recursion depth exceeded"
Expected behavior
It should be able to save
Additional context
In Odoo, there are 2 methods in the AccountAccount class called _compute_code and _inverse_code.
Auditlog module keeps triggering these 2 methods and causing an infinite loop.