Skip to content

[IMP] session_db: add method delete_from_identifiers #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maq-adhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+13 −0
Open

[IMP] session_db: add method delete_from_identifiers #3415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions session_db/pg_session_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,19 @@ def vacuum(self, max_lifetime=http.SESSION_LIFETIME):
(f"{max_lifetime} seconds",),
)

@with_lock
@with_cursor
def delete_from_identifiers(self, identifiers: list[str]) -> None:
for identifier in identifiers:
if not sessions._sha1_re.match(identifier):

@sbidoul sbidoul Nov 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_sha1_re is not the same regex as _session_identifier_re. Why do you change this?

@maq-adhoc maq-adhoc Nov 20, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sbidoul
The module imports the sessions class from odoo.tools._vendor import sessions.

The generate_key method it calls is this one: https://github.com/odoo/odoo/blob/18.0/odoo/tools/_vendor/sessions.py#L33-L37 which creates a SHA (40 characters) and not a 42-character identifier.

I understand that we could modify the FilesystemSessionStore class to inherit from FilesystemSessionStore (https://github.com/odoo/odoo/blob/18.0/odoo/http.py#L911) and ensure consistent behavior. However, we would have to remove the validations to avoid errors with existing sessions.

Since we are on a stable version with many productive installations, I prefer to be conservative with the changes. I look forward to hearing your opinion.

@sbidoul sbidoul Nov 20, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. And in 19, we don't have that problem because we use the generate_key method from FileSystemSessionStore here:

server-tools/session_db/pg_session_store.py

Line 142 in 7937302

generate_key = http.FilesystemSessionStore.generate_key

Is that right?

So maybe we should do the same here, and support both regexes in delete_from_identifiers?

@tarteo tarteo Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we validate the input anyways?

Isn't it faster to do an IN operation?
https://github.com/OCA/server-tools/pull/3662/changes#diff-d813321f73ce1687539ce0923c3e35057a0c7c2be7ae3f11ae43a30bcf6cd1bbR158-R166

raise ValueError(
"Identifier format incorrect, "
"did you pass in a string instead of a list?"
)
self._cr.execute(
"DELETE FROM http_sessions WHERE sid LIKE %s||'%%'", (identifier,)
)


_original_session_store = http.root.__class__.session_store

Expand Down